Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump httpx to 0.23.0 #72573

Merged
merged 3 commits into from May 27, 2022
Merged

Bump httpx to 0.23.0 #72573

merged 3 commits into from May 27, 2022

Conversation

uvjustin
Copy link
Contributor

Bump httpcore to 0.15.0
Bump anyio to 3.6.1

Proposed change

encode/httpx@0.22.0...0.23.0
encode/httpcore@0.14.7...0.15.0
agronholm/anyio@3.5.0...3.6.1

In particular, encode/httpx@3350d7e may help resolve various HA issues coming from httpx.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 馃 Silver
  • 馃 Gold
  • 馃弳 Platinum

To help with the load of incoming pull requests:

Bump httpcore to 0.15.0
Bump anyio to 3.6.1
@uvjustin uvjustin requested a review from a team as a code owner May 27, 2022 04:27
@probot-home-assistant probot-home-assistant bot added core small-pr PRs with less than 30 lines. labels May 27, 2022
@bdraco
Copy link
Member

bdraco commented May 27, 2022

Testing this now. Took care of resolving the conflict as well

@bdraco
Copy link
Member

bdraco commented May 27, 2022

Nothing obvious broke with the new version

@bdraco
Copy link
Member

bdraco commented May 27, 2022

Calls look ok
Screen Shot 2022-05-26 at 18 48 01

@bdraco
Copy link
Member

bdraco commented May 27, 2022

Screen Shot 2022-05-26 at 18 48 53

@bdraco
Copy link
Member

bdraco commented May 27, 2022

cc @flacjacket in case this improves the situation for amcrest

@bdraco
Copy link
Member

bdraco commented May 27, 2022

Should we tag this for 2022.6? encode/httpx#2156 seems like an important fix

@bdraco
Copy link
Member

bdraco commented May 27, 2022

Bumped a few more production systems and everything looks good

@balloob balloob added this to the 2022.6.0 milestone May 27, 2022
@balloob
Copy link
Member

balloob commented May 27, 2022

Early enough in the beta cycle, let's pull it in.

@bdraco bdraco merged commit 01b5f98 into home-assistant:dev May 27, 2022
balloob pushed a commit that referenced this pull request May 27, 2022
Co-authored-by: J. Nick Koston <nick@koston.org>
@github-actions github-actions bot locked and limited conversation to collaborators May 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants