Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update slixmpp to 1.8.2 #69794

Merged
merged 1 commit into from Apr 10, 2022
Merged

Conversation

michaeldavie
Copy link
Contributor

Proposed change

This updates corrects an issue introduced in #68080, which was caused by slixmpp introducing defusedxml in 1.8.0. This change caused a conflict with the environment_canada integration when the xmpp component was used.

slixmpp release details for 1.8.1 and 1.8.2: https://lab.louiz.org/poezio/slixmpp/-/releases

Big thanks to @gwww, @kwkid, and @mcfarlde for investigating!

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 馃 Silver
  • 馃 Gold
  • 馃弳 Platinum

To help with the load of incoming pull requests:

@probot-home-assistant
Copy link

Hey there @fabaff, @flowolf, mind taking a look at this pull request as it has been labeled with an integration (xmpp) you are listed as a code owner for? Thanks!
(message by CodeOwnersMention)

@frenck frenck added this to the 2022.4.2 milestone Apr 10, 2022
@frenck frenck added the smash Indicator this PR is close to finish for merging or closing label Apr 10, 2022
Dev automation moved this from Needs review to Reviewer approved Apr 10, 2022
@thecode thecode merged commit c98d120 into home-assistant:dev Apr 10, 2022
Dev automation moved this from Reviewer approved to Done Apr 10, 2022
balloob pushed a commit that referenced this pull request Apr 11, 2022
@balloob balloob mentioned this pull request Apr 11, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Apr 12, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bugfix cherry-picked cla-signed dependency dependency-bump integration: xmpp small-pr PRs with less than 30 lines. smash Indicator this PR is close to finish for merging or closing
Projects
Dev
  
Done
Development

Successfully merging this pull request may close these issues.

Environment Canada: Unexpected error fetching environment_canada radar data
6 participants