Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle expired credentials in reauth in google calendar initialization #69772

Merged
merged 5 commits into from Apr 10, 2022

Conversation

allenporter
Copy link
Contributor

Proposed change

Update google calendar init to handle expired credentials and trigger the reauth flow to refresh credentials. Also includes some text fixes that were copy/pasted from nest integration, including message shown during reauth.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 馃 Silver
  • 馃 Gold
  • 馃弳 Platinum

To help with the load of incoming pull requests:

@project-bot project-bot bot added this to Needs review in Dev Apr 9, 2022
@project-bot project-bot bot moved this from Needs review to By Code Owner in Dev Apr 9, 2022
homeassistant/components/google/__init__.py Outdated Show resolved Hide resolved
homeassistant/components/google/__init__.py Outdated Show resolved Hide resolved
Dev automation moved this from By Code Owner to Reviewer approved Apr 10, 2022
@MartinHjelmare
Copy link
Member

Tag for a patch release?

allenporter and others added 2 commits April 9, 2022 19:04
Co-authored-by: Martin Hjelmare <marhje52@gmail.com>
Co-authored-by: Martin Hjelmare <marhje52@gmail.com>
@allenporter allenporter added this to the 2022.4.2 milestone Apr 10, 2022
@allenporter
Copy link
Contributor Author

Tag for a patch release?

I was of two minds on this: My impression was this integration did not support re-auth before so its not a new regression. However, I think it could help get users our of a bad state, or it may help fix a case I don't understand yet. Generally, this seems fairly low risk though so let's go for it.

@balloob balloob merged commit a063f55 into home-assistant:dev Apr 10, 2022
Dev automation moved this from Reviewer approved to Done Apr 10, 2022
balloob pushed a commit that referenced this pull request Apr 11, 2022
#69772)

Co-authored-by: Martin Hjelmare <marhje52@gmail.com>
@balloob balloob mentioned this pull request Apr 11, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Apr 12, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Dev
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

4 participants