Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't test config on yaml import for generic camera #69714

Merged

Conversation

davet2001
Copy link
Contributor

@davet2001 davet2001 commented Apr 9, 2022

Proposed change

The generic camera config flow includes tests for the still and stream URLs to help the user only enter valid settings. However, running these checks during yaml import has caused several problems:

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 馃 Silver
  • 馃 Gold
  • 馃弳 Platinum

To help with the load of incoming pull requests:

@project-bot project-bot bot added this to Needs review in Dev Apr 9, 2022
@project-bot project-bot bot moved this from Needs review to By Code Owner in Dev Apr 9, 2022
@davet2001 davet2001 changed the title Don't test config on yaml import for generic Don't test config on yaml import for generic camera Apr 9, 2022
return self.async_abort(reason="unknown")
still_format = import_config.get(CONF_CONTENT_TYPE, "image/jpeg")
import_config[CONF_CONTENT_TYPE] = still_format
await self.async_set_unique_id(self.flow_id)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why even set a unique ID if you just use a random ID ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought that this was necessary, but obviously it's not!

Dev automation moved this from By Code Owner to Reviewer approved Apr 9, 2022
@balloob balloob merged commit 6fd041b into home-assistant:dev Apr 9, 2022
Dev automation moved this from Reviewer approved to Done Apr 9, 2022
@davet2001
Copy link
Contributor Author

@balloob please can this go into 2022.4.2?

@github-actions github-actions bot locked and limited conversation to collaborators Apr 10, 2022
@balloob balloob added this to the 2022.4.2 milestone Apr 11, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Dev
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants