Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gracefully handle missing summary in google calendar #69520

Merged
merged 1 commit into from Apr 7, 2022

Conversation

allenporter
Copy link
Contributor

@allenporter allenporter commented Apr 7, 2022

Proposed change

Gracefully handle empty summary in google calendar matching the old behavior
before some code cleanup.

Traceback (most recent call last):
  File "/usr/src/homeassistant/homeassistant/helpers/entity_platform.py", line 431, in _async_add_entity
    await entity.async_device_update(warning=False)
  File "/usr/src/homeassistant/homeassistant/helpers/entity.py", line 735, in async_device_update
    await task
  File "/usr/src/homeassistant/homeassistant/components/google/calendar.py", line 186, in async_update
    (summary, offset) = extract_offset(self._event["summary"], self._offset)
KeyError: 'summary'

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 馃 Silver
  • 馃 Gold
  • 馃弳 Platinum

To help with the load of incoming pull requests:

Gracefully handle empty summary in google calendar matching the old behavior
before some code cleanup.
@allenporter allenporter added this to the 2022.4.2 milestone Apr 7, 2022
@project-bot project-bot bot added this to Needs review in Dev Apr 7, 2022
@project-bot project-bot bot moved this from Needs review to By Code Owner in Dev Apr 7, 2022
@allenporter allenporter changed the title Gracefully handle empty summary in google calendar Gracefully handle missing summary in google calendar Apr 7, 2022
Dev automation moved this from By Code Owner to Reviewer approved Apr 7, 2022
@MartinHjelmare MartinHjelmare merged commit 10a1b1f into home-assistant:dev Apr 7, 2022
Dev automation moved this from Reviewer approved to Done Apr 7, 2022
@frenck frenck modified the milestones: 2022.4.2, 2022.4.1 Apr 7, 2022
@frenck
Copy link
Member

frenck commented Apr 7, 2022

Changed milestone target, as .4.1 isn't shipped yet.

frenck pushed a commit that referenced this pull request Apr 7, 2022
Gracefully handle empty summary in google calendar matching the old behavior
before some code cleanup.
@frenck frenck mentioned this pull request Apr 7, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Apr 8, 2022
@allenporter allenporter deleted the calendar-summary branch April 16, 2022 17:11
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Dev
  
Done
Development

Successfully merging this pull request may close these issues.

Google Calendar throw in error
4 participants