Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore IPv6 link local address on ssdp discovery in Fritz!Smarthome #69455

Conversation

mib1185
Copy link
Contributor

@mib1185 mib1185 commented Apr 6, 2022

Breaking change

Proposed change

This will solve the issue while updating from <=2022.3.x to 2022.4.1, but unfortunately not for updating from 2022.4.0 to 2022.4.1. In this case you need to re-add the fritzbox integration

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

@probot-home-assistant
Copy link

Hey there @flabbamann, mind taking a look at this pull request as it has been labeled with an integration (fritzbox) you are listed as a code owner for? Thanks!
(message by CodeOwnersMention)

@mib1185 mib1185 added this to the 2022.4.1 milestone Apr 6, 2022
@balloob balloob merged commit 95421b1 into home-assistant:dev Apr 6, 2022
@balloob balloob mentioned this pull request Apr 7, 2022
@mib1185 mib1185 deleted the fritzbox/ignore-ip6-link-local-on-ssdp-discovery branch April 7, 2022 07:53
@github-actions github-actions bot locked and limited conversation to collaborators Apr 8, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Could not authenticate AVM Fritz integration
3 participants