Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix telegram broadcast #69452

Merged
merged 1 commit into from
Apr 6, 2022
Merged

Fix telegram broadcast #69452

merged 1 commit into from
Apr 6, 2022

Conversation

balloob
Copy link
Member

@balloob balloob commented Apr 6, 2022

Breaking change

Proposed change

Fixes #69445

Unable to test this myself. @wicol can you take a look?

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

Sorry, something went wrong.

"""Set up the Telegram broadcast platform."""
bot = initialize_bot(config)
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is no longer necessary because it's done before calling async_setup_platform and is passed to async_setup_platform: https://github.com/home-assistant/core/blob/dev/homeassistant/components/telegram_bot/__init__.py#L322-L329



@pytest.fixture(autouse=True)
def clear_dispatcher():
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Moved this to the test_telegram_bot.py where it's actually used.

@balloob balloob merged commit c765e11 into dev Apr 6, 2022
@balloob balloob deleted the fix-telegram-broadcast branch April 6, 2022 17:44
balloob added a commit that referenced this pull request Apr 7, 2022
@balloob balloob mentioned this pull request Apr 7, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Apr 8, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

telegram_bot does not start after upgrading to 2022.4.0
2 participants