New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update python-mpd2 to 3.0.5 #69304
Update python-mpd2 to 3.0.5 #69304
Conversation
fix home-assistant#59006 python3.10 bug Unexpected keyword argument 'loop'
Hey there @fabaff, mind taking a look at this pull request as it has been labeled with an integration ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for bumping the dependency! However, could you please update the PR description to contain at least one (or multiple) of the following:
- A link to the release notes of this package version, and all versions in between.
- A link to the changelog of this package.
- A link to a Git(Hub) diff/compare view from the current version to the bumped version.
This allows us to review upstream changes, which is needed to decide this change is working as intended and/or if we can include it in, for example, a patch release of Home Assistant.
Thanks already! 馃憤
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @azrdev 馃憤
Proposed change
Update python-mpd2 to 3.0.5
Fix #59006: python3.10 bug
Unexpected keyword argument 'loop'
when using "mpd" integrationupstream information:
Type of change
Additional information
Checklist
black --fast homeassistant tests
)If user exposed functionality or configuration variables are added/changed:- Documentation added/updated for www.home-assistant.io
- The manifest file has all fields filled out correctly.
- New or updated dependencies have been added to
- For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
- Untested files have been added to
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.The integration reached or maintains the following Integration Quality Scale:
To help with the load of incoming pull requests: