Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update python-mpd2 to 3.0.5 #69304

Merged
merged 1 commit into from Apr 10, 2022
Merged

Conversation

azrdev
Copy link
Contributor

@azrdev azrdev commented Apr 4, 2022

Proposed change

Update python-mpd2 to 3.0.5
Fix #59006: python3.10 bug Unexpected keyword argument 'loop' when using "mpd" integration

upstream information:

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.
If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 馃 Silver
  • 馃 Gold
  • 馃弳 Platinum

To help with the load of incoming pull requests:

fix home-assistant#59006 python3.10 bug Unexpected keyword argument 'loop'
@azrdev azrdev requested a review from fabaff as a code owner April 4, 2022 20:11
@homeassistant
Copy link
Contributor

Hi @azrdev,

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

@probot-home-assistant
Copy link

Hey there @fabaff, mind taking a look at this pull request as it has been labeled with an integration (mpd) you are listed as a code owner for? Thanks!
(message by CodeOwnersMention)

Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for bumping the dependency! However, could you please update the PR description to contain at least one (or multiple) of the following:

  • A link to the release notes of this package version, and all versions in between.
  • A link to the changelog of this package.
  • A link to a Git(Hub) diff/compare view from the current version to the bumped version.

This allows us to review upstream changes, which is needed to decide this change is working as intended and/or if we can include it in, for example, a patch release of Home Assistant.

Thanks already! 馃憤

@azrdev azrdev requested a review from frenck April 9, 2022 13:26
@frenck frenck added this to the 2022.4.2 milestone Apr 10, 2022
Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @azrdev 馃憤

@frenck frenck merged commit afd21e4 into home-assistant:dev Apr 10, 2022
balloob pushed a commit that referenced this pull request Apr 11, 2022
@balloob balloob mentioned this pull request Apr 11, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Apr 12, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MPD + Python 3.10 = Unexpected keyword argument 'loop'
5 participants