Replace in-place lists with tuples (1) #53684
Conversation
cdce8p
requested review from
balloob,
bdraco,
bieniu,
cgtobi,
chemelli74,
ctalkington,
Danielhiversen,
dgomes,
elupus,
emontnemery,
fabaff,
frenck,
jjlawren,
Kane610,
ludeeus,
michaelarnauts,
pavoni,
rytilahti,
syssi,
thecode and
a team
as code owners
| @@ -81,7 +81,7 @@ async def async_setup(hass, config): | |||
| options = {} | |||
| mode = conf.get(CONF_MODE, MODE_ROUTER) | |||
| for name, value in conf.items(): | |||
| if name in ([CONF_DNSMASQ, CONF_INTERFACE, CONF_REQUIRE_IP]): | |||
| if name in (CONF_DNSMASQ, CONF_INTERFACE, CONF_REQUIRE_IP): | |||
There was a problem hiding this comment.
Should we not be consistent? There are tuples ending with , and not
There was a problem hiding this comment.
This is somewhat special. The parentheses here weren't used before, i.e.
([CONF_DNSMASQ, CONF_INTERFACE, CONF_REQUIRE_IP]) == [CONF_DNSMASQ, CONF_INTERFACE, CONF_REQUIRE_IP]There wasn't a trailing comma, so no tuple.
Take a look at the next line as well: if name == CONF_REQUIRE_IP .... That suggests that it should only be a normal list / tuple. Not a tuple of tuples.
There was a problem hiding this comment.
Sure, I took this as an example (bad one), but it's still mixed and matched everywhere
There was a problem hiding this comment.
You normally don't need a trailing comma for tuples. Only if there is just one value.
I won't recommend adding additional once either as this would change the formatting with black.
| @@ -180,7 +180,7 @@ def __init__(self, name, device, entry, unique_id, coordinator): | |||
| self._min_humidity = 30 | |||
| self._max_humidity = 80 | |||
| self._humidity_steps = 10 | |||
| elif self._model in [MODEL_AIRHUMIDIFIER_CA4]: | |||
| elif self._model in (MODEL_AIRHUMIDIFIER_CA4,): | |||
There was a problem hiding this comment.
Maybe better:
elif self._model == MODEL_AIRHUMIDIFIER_CA4:There was a problem hiding this comment.
@bieniu The focus for this PR was to only replace lists with tuples. It doesn't really make sense to change one or two more these into equality checks. I might consider adding another pylint check for it to replace all of them at once.
|
As I wrote in #53686 (comment), I think the right change would be to use sets for lookups instead of lists or tuples. Those are designed and tuned precisely for this usage. |
I disagree with that. As performance wise, there is no real world difference, using tuples everywhere will make it easier for beginners to understand when to use them. For my full argument see: pylint-dev/pylint#4776 (comment) |
|
Closing this after discussion in pylint-dev/pylint#4776 |
Proposed change
Followup to #53147
Replace in-place defined lists with tuples.
Example
A check for it will be included with the next
pylintrelease: pylint-dev/pylint#4768Type of change
Additional information
Checklist
black --fast homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.The integration reached or maintains the following Integration Quality Scale:
To help with the load of incoming pull requests: