-
-
Notifications
You must be signed in to change notification settings - Fork 28.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Block older versions of custom integration mydolphin_plus since they cause crashes #117751
Conversation
It's kind of strong to say it crashes when in fact all post in issues are about disconnection of the broker without reconnect |
We could change it to "performs non-thread-safe operations which may cause a crash" but I don't think users will understand what that means |
The initial post in the linked issue also mentions that it's causing a crash for them eventually. So, crashes do seem to actively happen because of the non-thread-safe operations. |
complaints are about crashes that being reported when ppl were asked what exactly happens they wrote that the connection is fetting lost, there is an issue caused by unsafe thread failure, but it doesn't crash the HA, |
What is the lowest version number where all thread safety and connection issues are fixed? |
v1.0.12 |
That doesn't seem correct since there is a change from |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @bdraco 👍
../Frenck
Proposed change
Block older versions of custom integration mydolphin_plus since they cause crashes
sh00t2kill/dolphin-robot#185
Type of change
Additional information
Checklist
ruff format homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.To help with the load of incoming pull requests: