Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Block older versions of custom integration mydolphin_plus since they cause crashes #117751

Merged
merged 2 commits into from
May 20, 2024

Conversation

bdraco
Copy link
Member

@bdraco bdraco commented May 20, 2024

Proposed change

Block older versions of custom integration mydolphin_plus since they cause crashes

sh00t2kill/dolphin-robot#185

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@bdraco bdraco requested a review from a team as a code owner May 20, 2024 00:06
@home-assistant home-assistant bot added cla-signed core small-pr PRs with less than 30 lines. labels May 20, 2024
@bdraco bdraco added this to the 2024.5.5 milestone May 20, 2024
@elad-bar
Copy link

It's kind of strong to say it crashes when in fact all post in issues are about disconnection of the broker without reconnect

@bdraco
Copy link
Member Author

bdraco commented May 20, 2024

We could change it to "performs non-thread-safe operations which may cause a crash" but I don't think users will understand what that means

@TheJulianJES
Copy link
Contributor

The initial post in the linked issue also mentions that it's causing a crash for them eventually. So, crashes do seem to actively happen because of the non-thread-safe operations.

@elad-bar
Copy link

complaints are about crashes that being reported when ppl were asked what exactly happens they wrote that the connection is fetting lost, there is an issue caused by unsafe thread failure, but it doesn't crash the HA,
In v1.0.11 it could crash, but since 1.0.12 it was about lost connection without ability to recover it up until reload integration,
1.0.12 was released short after HA demanded to change the code with the threadsafe (which is totally make sense).

@bdraco
Copy link
Member Author

bdraco commented May 20, 2024

What is the lowest version number where all thread safety and connection issues are fixed?

@elad-bar
Copy link

v1.0.12

@bdraco
Copy link
Member Author

bdraco commented May 20, 2024

homeassistant/loader.py Outdated Show resolved Hide resolved
Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @bdraco 👍

../Frenck

@frenck frenck merged commit d11003e into dev May 20, 2024
34 checks passed
@frenck frenck deleted the block_older_dolphin branch May 20, 2024 07:45
bajansen pushed a commit to bajansen/homeassistant that referenced this pull request May 20, 2024
@github-actions github-actions bot locked and limited conversation to collaborators May 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants