Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump pyinsteon to 1.6.1 #117196

Merged
merged 3 commits into from May 11, 2024
Merged

Conversation

teharris1
Copy link
Contributor

@teharris1 teharris1 commented May 10, 2024

Proposed change

Upgrade the pyinsteon module to 1.6.0. This addresses the following issues:

  • Ability to track the I3 Dial on level during manual changes at the dial
  • Remove a race condition for with device status commands
  • Improved remote linking

Full change log:
pyinsteon: pyinsteon/pyinsteon@1.5.3...1.6.1

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@TheJulianJES TheJulianJES changed the title Bump pyinsteon Bump pyinsteon to 1.6.0 May 10, 2024
@TheJulianJES TheJulianJES changed the title Bump pyinsteon to 1.6.0 Bump pyinsteon to 1.6.1 May 10, 2024
Copy link
Contributor

@TheJulianJES TheJulianJES left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your description and diff only links to version 1.6.0.
Please update it to point to the correct version (1.6.1).

@teharris1
Copy link
Contributor Author

BTW, the failed test is not related to this PR

@balloob
Copy link
Member

balloob commented May 11, 2024

That's what they all say 😝

@TheJulianJES TheJulianJES mentioned this pull request May 11, 2024
20 tasks
@balloob balloob merged commit a892062 into home-assistant:dev May 11, 2024
33 of 34 checks passed
dgomes pushed a commit to dgomes/home-assistant that referenced this pull request May 11, 2024
* Bump pyinsteon

* Bump pyinsteon

---------

Co-authored-by: Paulus Schoutsen <balloob@gmail.com>
@github-actions github-actions bot locked and limited conversation to collaborators May 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

HA does not capture Insteon i3 Dial Dimmer level
3 participants