Implement runtime data for Plugwise #117172
Conversation
|
Hey there @CoMPaTech, @frenck, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
| @@ -59,6 +59,12 @@ def async_migrate_entity_entry(entry: er.RegistryEntry) -> dict[str, Any] | None | |||
| "-slave_boiler_state", "-secondary_boiler_state" | |||
| ) | |||
| } | |||
| if entry.domain == Platform.SENSOR and entry.unique_id.endswith( | |||
There was a problem hiding this comment.
I don't understand why we add this or why we change tests in this PR. It should just be a refactor.
There was a problem hiding this comment.
After implementing the refactor some tests failed.
I needed to add the below code and update the test-file to obtain a test-pass.
I'm seeing these strange issues, tests passing when they should fail, quite regularly in our Plugwise-beta github. This I normally resolve by deleting the caches under Actions - Caches.
There was a problem hiding this comment.
If tests need to be adjusted that should happen separately. A refactor shouldn't change the test result. Then the tests aren't correctly written.
Proposed change
Implement runtime data for Plugwise.
And apparently some migration-code was not added in the past, the tests fails on it in this PR, so added.
Looks like this is caused by the
SENSOR_DOMAINtoPlatform.SENSORchange.Also some small test-fixture errors were corrected.
Type of change
Additional information
Checklist
ruff format homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.To help with the load of incoming pull requests: