Cleanup useless suppressions #117166
Draft
Cleanup useless suppressions #117166
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
autinerd
requested review from
hunterjm,
balloob,
a team,
chemelli74,
mib1185,
bdraco and
davet2001
as code owners
home-assistant
bot
added
cla-signed
code-quality
core
small-pr
| @@ -42,7 +42,7 @@ async def async_setup_entry(hass: HomeAssistant, entry: ConfigEntry) -> bool: | |||
| await hass.async_add_executor_job(api.connect) | |||
| except (ConnectionRefusedError, TimeoutError, SSLError) as ex: | |||
| raise ConfigEntryNotReady("Connection to Deluge Daemon failed") from ex | |||
| except Exception as ex: # noqa: BLE001 | |||
| except Exception as ex: | |||
There was a problem hiding this comment.
Why is the noqa not needed here?
There was a problem hiding this comment.
Because of the raise from inside
There was a problem hiding this comment.
But it's not raised in all cases.
There was a problem hiding this comment.
Yes, that is currently not taken into account. I can revert this and fix it in Ruff.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
This cleans up useless suppressions for Ruff and Pylint.
This also moves the RUF100 rule to the ignore section.
Type of change
Additional information
Checklist
ruff format homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.To help with the load of incoming pull requests: