New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix peco integration #117165
base: dev
Are you sure you want to change the base?
Fix peco integration #117165
Conversation
If this could be in the next patch that would be great 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
manifest, requirements and test requirements changed. All peco related unit tests run locally without errors.
97ff4bd
to
5c43b91
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems like there are multiple things going on here. A dependency dymb and some refactoring. These seem to be unrelated (and such thus be in separate PRs).
Looking upstream, I noticed there are no releases or version tags to be found there. I would strongly encourage you to add those to the GitHub project of the library (enhancing the transparency and adds clarity).
Last but not least, there are some weird files there now in the recent commits. Like:
The file cannot be viewed with GitHub (that seems specifically an issue on GitHub's end, which you might want to report with them?) anyways, I'm not sure why it is there.
../Frenck
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
👍 I will remove refactoring and add release tags. Was the first library I've ever made so 😅
I noticed that file too, but when I tried to open it on VS Code it just threw some error saying the file didn't exist (??). I'm thinking of just redoing the local repo on my system and trying to clean that file out. |
Proposed change
Bump
peco-outage-api
to version 0.0.30Diff here
Type of change
Additional information
Checklist
ruff format homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.To help with the load of incoming pull requests: