Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix peco integration #117165

Draft
wants to merge 2 commits into
base: dev
Choose a base branch
from
Draft

Conversation

IceBotYT
Copy link
Contributor

@IceBotYT IceBotYT commented May 9, 2024

Proposed change

Bump peco-outage-api to version 0.0.30
Diff here

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@IceBotYT
Copy link
Contributor Author

IceBotYT commented May 9, 2024

If this could be in the next patch that would be great 👍

Copy link

@NECH2004 NECH2004 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

manifest, requirements and test requirements changed. All peco related unit tests run locally without errors.

@IceBotYT IceBotYT changed the title Bump peco to 0.0.30 Fix peco integration May 19, 2024
Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👋 @IceBotYT

It seems like there are multiple things going on here. A dependency dymb and some refactoring. These seem to be unrelated (and such thus be in separate PRs).

Looking upstream, I noticed there are no releases or version tags to be found there. I would strongly encourage you to add those to the GitHub project of the library (enhancing the transparency and adds clarity).

Last but not least, there are some weird files there now in the recent commits. Like:

CleanShot 2024-05-20 at 10 52 33@2x

The file cannot be viewed with GitHub (that seems specifically an issue on GitHub's end, which you might want to report with them?) anyways, I'm not sure why it is there.

../Frenck

@home-assistant home-assistant bot marked this pull request as draft May 20, 2024 08:55
@home-assistant
Copy link

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@IceBotYT
Copy link
Contributor Author

👍 I will remove refactoring and add release tags. Was the first library I've ever made so 😅
But with this:

The file cannot be viewed with GitHub (that seems specifically an issue on GitHub's end, which you might want to report with them?) anyways, I'm not sure why it is there.

../Frenck

I noticed that file too, but when I tried to open it on VS Code it just threw some error saying the file didn't exist (??). I'm thinking of just redoing the local repo on my system and trying to clean that file out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PECO Outage Counter inoperative
3 participants