Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump pysignalclirestapi to 0.3.24 #117148

Draft
wants to merge 2 commits into
base: dev
Choose a base branch
from

Conversation

r-xyz
Copy link

@r-xyz r-xyz commented May 9, 2024

pysignalclirestapi v0.3.24 enables "text_mode" for the Signal Messenger integration.

Changelog: bbernhard/pysignalclirestapi@0.3.23...0.3.24

Breaking change

Proposed change

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@home-assistant
Copy link

home-assistant bot commented May 9, 2024

Hey there @bbernhard, mind taking a look at this pull request as it has been labeled with an integration (signal_messenger) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of signal_messenger can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign signal_messenger Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

@bbernhard
Copy link
Contributor

Are you sure that those changes are enough? I think for the text_mode parameter to work, there are also changes in the signal integration needed.

Copy link

@NECH2004 NECH2004 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mainfest, requirements_all.txt and requirements_test_all.txt are changed. Looks ok.

@r-xyz
Copy link
Author

r-xyz commented May 9, 2024

@bbernhard thanks for the heads up, I ran the local tests but I could not double check with a real instance.
After a more in depth look, you are right, code should be modified for the additional parameter to be passed.
Will update as soon as I can get to my workstation.

@r-xyz r-xyz marked this pull request as draft May 9, 2024 19:07
@r-xyz
Copy link
Author

r-xyz commented May 19, 2024

@bbernhard I added the parameter in notify.py.
Could you please have a look if it makes sense? Thank you.

I followed the example of other additional parameters, though I am wondering if it could be moved to the main data structure:
from

action:
  service: notify.NOTIFIER_NAME
  data:
    message: "Test **message**"
    data:
      text_mode: "styled"

to

action:
  service: notify.NOTIFIER_NAME
  data:
    message: "Test **message**"
    text_mode: "styled"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants