New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump pysignalclirestapi to 0.3.24 #117148
base: dev
Are you sure you want to change the base?
Conversation
Hey there @bbernhard, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
Are you sure that those changes are enough? I think for the text_mode parameter to work, there are also changes in the signal integration needed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
mainfest, requirements_all.txt and requirements_test_all.txt are changed. Looks ok.
@bbernhard thanks for the heads up, I ran the local tests but I could not double check with a real instance. |
@bbernhard I added the parameter in notify.py. I followed the example of other additional parameters, though I am wondering if it could be moved to the main data structure: action:
service: notify.NOTIFIER_NAME
data:
message: "Test **message**"
data:
text_mode: "styled" to action:
service: notify.NOTIFIER_NAME
data:
message: "Test **message**"
text_mode: "styled" |
pysignalclirestapi v0.3.24 enables "text_mode" for the Signal Messenger integration.
Changelog: bbernhard/pysignalclirestapi@0.3.23...0.3.24
Breaking change
Proposed change
Type of change
Additional information
Checklist
ruff format homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.To help with the load of incoming pull requests: