New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for V2C Trydan 2.1.7 #117147
base: dev
Are you sure you want to change the base?
Add support for V2C Trydan 2.1.7 #117147
Conversation
if coordinator.data.ID and entry.unique_id != coordinator.data.ID: | ||
hass.config_entries.async_update_entry(entry, unique_id=coordinator.data.ID) | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can use a minor version migration for this
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I must have backwards compatibility with firmwares that don't provide the device ID
Co-authored-by: Joost Lekkerkerker <joostlek@outlook.com>
Co-authored-by: Joost Lekkerkerker <joostlek@outlook.com>
Co-authored-by: Joost Lekkerkerker <joostlek@outlook.com>
* Refactor V2C tests
key="slave_error", | ||
translation_key="slave_error", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this be called slave status? (Or maybe use a different name for slave if possible). Since a state can be no error, while the name assumes it's an error
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm following the manufacturer documentation, changing this would be inconsistent with the manufacturer documentation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But reading the states, not everything is an error, reading, writing etc isn't an error
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Proposed change
The release of a new firmware version (2.1.7) has triggered some new errors (corrected in the upstream library) and two extra sensors.
There is a minor version bump to address constants misspelling: dgomes/pytrydan@v0.6.0...v0.6.1
Type of change
Additional information
Checklist
ruff format homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.To help with the load of incoming pull requests: