Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for V2C Trydan 2.1.7 #117147

Open
wants to merge 22 commits into
base: dev
Choose a base branch
from
Open

Conversation

dgomes
Copy link
Contributor

@dgomes dgomes commented May 9, 2024

Proposed change

The release of a new firmware version (2.1.7) has triggered some new errors (corrected in the upstream library) and two extra sensors.

There is a minor version bump to address constants misspelling: dgomes/pytrydan@v0.6.0...v0.6.1

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

Comment on lines +34 to +36
if coordinator.data.ID and entry.unique_id != coordinator.data.ID:
hass.config_entries.async_update_entry(entry, unique_id=coordinator.data.ID)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can use a minor version migration for this

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I must have backwards compatibility with firmwares that don't provide the device ID

@joostlek joostlek marked this pull request as draft May 9, 2024 20:40
@dgomes dgomes marked this pull request as ready for review May 11, 2024 09:17
@dgomes dgomes marked this pull request as ready for review May 11, 2024 20:42
tests/components/v2c/test_sensor.py Outdated Show resolved Hide resolved
Comment on lines +83 to +84
key="slave_error",
translation_key="slave_error",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be called slave status? (Or maybe use a different name for slave if possible). Since a state can be no error, while the name assumes it's an error

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm following the manufacturer documentation, changing this would be inconsistent with the manufacturer documentation

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But reading the states, not everything is an error, reading, writing etc isn't an error

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMAGE 2024-05-11 22:46:42

except for the first state, everything is an error

Copy link
Contributor Author

@dgomes dgomes May 11, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the first 2 bytes indicate the slave brand/model and are not provided via HTTP only show up in the display
IMAGE 2024-05-11 22:48:19

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants