New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Ecovacs custom command event #117139
Add Ecovacs custom command event #117139
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
Hey there @OverloadUT, @mib1185, @edenhaus, @Augar, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
HA supports service call responses and we should use it for this usecase.
Can you create a new service call in the ecovacs integration for it?
I would call it send_custom_command
or something similar
@edenhaus The original send_command service already allows to send custom commands but restricts params to dict instead of dict | list (requested in some custom commands). Do I really need to write a specific method instead of editing the original send_command? |
I tried implementing the Service Response but it is not working. The deebot_client library does not return a response after a service call but, instead, generates an asyncronous event with the response. |
The only command that requires list instead of dict is getPos. I'm working on a PR that implements the same feature by using deebot_client library. |
Breaking change
Proposed change
Add the ability to send custom commands that requires list as params (i.e. getPos that needs a list with two values, "deebotPos" and "chargePos").
Send custom commands' response with a new "ecovacs_custom_command" event.
Type of change
Additional information
Checklist
ruff format homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.To help with the load of incoming pull requests: