New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Ecovacs supported lifespans #117134
base: dev
Are you sure you want to change the base?
Update Ecovacs supported lifespans #117134
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems you haven't yet signed a CLA. Please do so here.
Once you do that we will be able to review and accept this pull request.
Thanks!
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
Hey there @OverloadUT, @mib1185, @edenhaus, @Augar, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @Ulfmerbold2000
first, thanks for this contribution 👍 please add the related issue under "Additional information" as "fixes #...", further don't forget to signed the CLA (see #117134 (review))
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What i've seen in my tests, ALL Lifespan Entities are not updating like in the "App".
If i do reset the SideBrush for example, the app correspondents the change immediately, but after the "Brush" reset an actualisation only over "reload the integration" is showing the "renewed counter"
hope this helps
With regards
Sorry for my dumb question, but where i find the translation files for that integration? As you surely seen "github" is'nt my native playground so please be patient with me |
Translations are done with lokalize and the translations files are not checked in on github. More information about contributing to translation can be found https://developers.home-assistant.io/docs/translations |
Breaking change
Proposed change
Type of change
Additional information
Checklist
ruff format homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.To help with the load of incoming pull requests: