Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Ecovacs supported lifespans #117134

Draft
wants to merge 3 commits into
base: dev
Choose a base branch
from

Conversation

Ulfmerbold2000
Copy link

Breaking change

Proposed change

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

Copy link

@home-assistant home-assistant bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Ulfmerbold2000

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

@home-assistant
Copy link

home-assistant bot commented May 9, 2024

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@home-assistant home-assistant bot marked this pull request as draft May 9, 2024 08:37
@home-assistant
Copy link

home-assistant bot commented May 9, 2024

Hey there @OverloadUT, @mib1185, @edenhaus, @Augar, mind taking a look at this pull request as it has been labeled with an integration (ecovacs) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of ecovacs can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign ecovacs Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

Copy link
Contributor

@mib1185 mib1185 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @Ulfmerbold2000
first, thanks for this contribution 👍 please add the related issue under "Additional information" as "fixes #...", further don't forget to signed the CLA (see #117134 (review))

Copy link
Author

@Ulfmerbold2000 Ulfmerbold2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What i've seen in my tests, ALL Lifespan Entities are not updating like in the "App".

If i do reset the SideBrush for example, the app correspondents the change immediately, but after the "Brush" reset an actualisation only over "reload the integration" is showing the "renewed counter"

hope this helps

With regards

@Ulfmerbold2000
Copy link
Author

Sorry for my dumb question, but where i find the translation files for that integration?
I've done the Translation for the files de.json and en.json, but this directory from my HA-Installation is missing here in github.

As you surely seen "github" is'nt my native playground so please be patient with me
I've uploaded that files now here(the wrong place i'm sure, sorry for that):
de.json
en.json

@MartinHjelmare MartinHjelmare changed the title Ecovacs_Lifespan_20240509 Update Ecovacs supported lifespans May 9, 2024
@edenhaus
Copy link
Contributor

edenhaus commented May 9, 2024

Translations are done with lokalize and the translations files are not checked in on github. More information about contributing to translation can be found https://developers.home-assistant.io/docs/translations

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants