Fix telegram broadcast #69452
Merged
Fix telegram broadcast #69452
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
probot-home-assistant
bot
added
bugfix
has-tests
integration: telegram_bot
small-pr
balloob
commented
Apr 6, 2022
| """Set up the Telegram broadcast platform.""" | ||
| bot = initialize_bot(config) |
There was a problem hiding this comment.
This is no longer necessary because it's done before calling async_setup_platform and is passed to async_setup_platform: https://github.com/home-assistant/core/blob/dev/homeassistant/components/telegram_bot/__init__.py#L322-L329
balloob
commented
Apr 6, 2022
|
|
||
|
|
||
| @pytest.fixture(autouse=True) | ||
| def clear_dispatcher(): |
There was a problem hiding this comment.
Moved this to the test_telegram_bot.py where it's actually used.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Breaking change
Proposed change
Fixes #69445
Unable to test this myself. @wicol can you take a look?
Type of change
Additional information
Checklist
black --fast homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.The integration reached or maintains the following Integration Quality Scale:
To help with the load of incoming pull requests: