Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI is broken because of setuptools #50733

Closed
KapJI opened this issue May 16, 2021 · 3 comments · Fixed by #50734
Closed

CI is broken because of setuptools #50733

KapJI opened this issue May 16, 2021 · 3 comments · Fixed by #50734

Comments

@KapJI
Copy link
Member

KapJI commented May 16, 2021

The problem

@cdce8p it looks to me that broken CI is caused by setuptools 56.2.0 and pypa/setuptools#2640 specifically. Should we downgrade setuptools?

Example of failing job: https://github.com/home-assistant/core/pull/50722/checks?check_run_id=2594986952

What is version of Home Assistant Core has the issue?

dev

What was the last working version of Home Assistant Core?

No response

What type of installation are you running?

Home Assistant Core

Integration causing the issue

No response

Link to integration documentation on our website

No response

Example YAML snippet

No response

Anything in the logs that might be useful for us?

No response

Additional information

No response

@cdce8p
Copy link
Member

cdce8p commented May 16, 2021

@KapJI Thanks for notifying me! I'll take a look, but for now a temporary downgrade would be the way to go, I guess.

@cdce8p
Copy link
Member

cdce8p commented May 16, 2021

With pypa/setuptools#2640 any install from a source distribution will fail if the license field is not string formatted, which it should be.

The issue here is with freesms as the license is of type bytes and not string. I opened a PR upstream to fix it: bfontaine/freesms#7

I suspect this might not be the only occurrence. Will we see.

@cdce8p
Copy link
Member

cdce8p commented May 16, 2021

Just checked, freesms is the only issue. So we should be able to move to 56.2.0 once the PR is merged.

@github-actions github-actions bot locked and limited conversation to collaborators Jun 16, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants