Add more type hints #3499
Merged
Add more type hints #3499
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarcSkovMadsen
commented
May 7, 2022
MarcSkovMadsen
commented
May 7, 2022
MarcSkovMadsen
commented
May 7, 2022
MarcSkovMadsen
commented
May 7, 2022
MarcSkovMadsen
changed the title
MarcSkovMadsen
commented
May 8, 2022
MarcSkovMadsen
commented
May 8, 2022
philippjfr
force-pushed
the
feature/add-typehints
branch
2 times, most recently
from
da70943
to
4644970
Compare
philippjfr
force-pushed
the
feature/add-typehints
branch
from
4644970
to
012c486
Compare
mattpap
reviewed
May 12, 2022
mattpap
reviewed
May 12, 2022
mattpap
reviewed
May 12, 2022
mattpap
reviewed
May 12, 2022
| @@ -256,33 +264,36 @@ def datetime_as_utctimestamp(value): | |||
| return value.replace(tzinfo=dt.timezone.utc).timestamp() * 1000 | |||
|
|
|||
|
|
|||
| def is_number(s): | |||
| def is_number(s: Any) -> bool: | |||
There was a problem hiding this comment.
It would be even better to make this a type guard def is_number(s: Any) -> TypeGuard[float] (needs typing_extensions for now). This way s will be known to be a float in if is_number(s): or after assert is_number(s).
|
I'm going to merge and continue in another PR. Otherwise we're inviting tons of merge conflicts. |
Codecov Report
@@ Coverage Diff @@
## master #3499 +/- ##
==========================================
- Coverage 82.80% 82.76% -0.05%
==========================================
Files 199 199
Lines 27296 27332 +36
==========================================
+ Hits 22603 22620 +17
- Misses 4693 4712 +19
Continue to review full report at Codecov.
|
philippjfr
added a commit
that referenced
this pull request
May 16, 2022
Co-authored-by: Marc Skov Madsen <masma@orsted.dk> Co-authored-by: Philipp Rudiger <prudiger@anaconda.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds typehints to button.py and selected dependencies.