Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvements for pyodide handling #3444

Merged
merged 2 commits into from Apr 23, 2022
Merged

Improvements for pyodide handling #3444

merged 2 commits into from Apr 23, 2022

Conversation

philippjfr
Copy link
Member

  • Add state._is_pyodide property to unify detection of pyodide context
  • Suppress warnings

@MarcSkovMadsen
Copy link
Collaborator

Would it not be nice for users to have public access to the property?

Then they can import in one way if in pyodide and another if not etc.

@philippjfr
Copy link
Member Author

Would it not be nice for users to have public access to the property?

On the one hand yes, but it's really not Panel's responsibility to handle this and in the long run pyodide may not be the only WASM runtime that is supported. So I'd prefer to keep this as private API for the time being.

@codecov
Copy link

codecov bot commented Apr 23, 2022

Codecov Report

Merging #3444 (552f11a) into master (2ba0b94) will decrease coverage by 0.00%.
The diff coverage is 77.77%.

@@            Coverage Diff             @@
##           master    #3444      +/-   ##
==========================================
- Coverage   82.92%   82.91%   -0.01%     
==========================================
  Files         198      198              
  Lines       27018    27014       -4     
==========================================
- Hits        22406    22400       -6     
- Misses       4612     4614       +2     
Impacted Files Coverage Δ
panel/io/pyodide.py 0.00% <0.00%> (ø)
panel/io/__init__.py 87.50% <100.00%> (ø)
panel/io/callbacks.py 72.99% <100.00%> (+0.33%) ⬆️
panel/io/state.py 69.08% <100.00%> (ø)
panel/io/reload.py 69.56% <0.00%> (-2.18%) ⬇️
panel/tests/command/test_serve.py 83.54% <0.00%> (-1.46%) ⬇️
panel/io/server.py 78.04% <0.00%> (-0.22%) ⬇️
panel/pane/idom.py 27.40% <0.00%> (+0.20%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2ba0b94...552f11a. Read the comment docs.

@philippjfr philippjfr merged commit 0cc5ab9 into master Apr 23, 2022
@philippjfr philippjfr deleted the pyodide_enhancements branch April 23, 2022 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants