External holo cli #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #17 +/- ##
==========================================
+ Coverage 53.05% 60.42% +7.36%
==========================================
Files 179 179
Lines 31760 31812 +52
==========================================
+ Hits 16850 19222 +2372
+ Misses 14910 12590 -2320 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Fréderic LOUI <frederic.loui@renater.fr>
frederic-loui
force-pushed
the
external-holo-cli
branch
from
cbbc2e3
to
8d360eb
Compare
rwestphal
added a commit
that referenced
this pull request
Apr 16, 2024
Update the build instructions to reflect the relocation of holo-cli to its own repository (see #17). Additionally, remove outdated comment from the Dockerfile. Signed-off-by: Renato Westphal <renato@opensourcerouting.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is related to issue 12.
It mainly deals with:
1- move
holo-cliin its own separate repository2- Adjustment of Cargo.toml
3-
holoContainerLab image adjustment