fix flaky test assertion apache#2667

fix flaky test assertion in org.apache.helix .rest.server.TestPerInstanceAccessor.testGetAllMessages
hofi1 · Oct 27, 2023 · 7f2c73c · 7f2c73c
1 parent 8567c69
commit 7f2c73c
Showing 1 changed file with 5 additions and 3 deletions.
diff --git a/helix-rest/src/test/java/org/apache/helix/rest/server/TestPerInstanceAccessor.java b/helix-rest/src/test/java/org/apache/helix/rest/server/TestPerInstanceAccessor.java
@@ -325,9 +325,11 @@ public void testGetAllInstances() throws IOException {
 
     Set<String> instances = OBJECT_MAPPER.readValue(instancesStr,
         OBJECT_MAPPER.getTypeFactory().constructCollectionType(Set.class, String.class));
-    Assert.assertEquals(instances.size(), _instancesMap.get(CLUSTER_NAME).size());
-    Assert.assertTrue(instances.containsAll(_instancesMap.get(CLUSTER_NAME)));
-    Assert.assertTrue(_instancesMap.get(CLUSTER_NAME).containsAll(instances));
+    String errorMessage = "Instances from response: "+ instances + " vs instances actually: "
+        + _instancesMap.get(CLUSTER_NAME);
+    Assert.assertEquals(instances.size(), _instancesMap.get(CLUSTER_NAME).size(), errorMessage);
+    Assert.assertTrue(instances.containsAll(_instancesMap.get(CLUSTER_NAME)), errorMessage);
+    Assert.assertTrue(_instancesMap.get(CLUSTER_NAME).containsAll(instances), errorMessage);
     System.out.println("End test :" + TestHelper.getTestMethodName());
   }