As a guest, I can register #23

hoangmirs · 2020-12-17T07:28:54Z

Solve #2

What happened 👀

Create a registration page
Testing will be implemented on As a guest, I can register - Testing #26

Insight 📝

Add registration feature, show flash messages when failed or succeeded
Add /register route
Create BaseController to add some common works that we re-use in several controllers
Add some helpers to encrypt password, set some common controller attributes, convert string
Split the tailwind's components into multiple files to resolve the slow-building bug when using Tailwind 2 + Webpack. Will merge them again when Tailwind fixed the issue
Add copy-webpack-plugin to copy the static assets to static folder

Proof Of Work 📹

Create successfully

Create failed

olivierobert

Early feedback

views/shared/header.html

olivierobert · 2020-12-18T07:04:51Z

conf/webpack.common.js

+      patterns: [
+        {
+          from: path.resolve(__dirname, "../assets/images"),
+          to: path.resolve(__dirname, "../static/images"),


Why is this needed?

We need to set the static path for the assets/images folder if we need to use it. But I want to put all static files in static folder, then I go with this, is it okay?

I am not sure of the motivation to move images to static/ 🤔 Do you mean that once the build is completed, the compiled JS and CSS would go to /static to you prefer to have images there too?

No, before I couldn't use assets from the assets folder, I have to set the static path to use it, then I went with putting all the static files in the same folder.
But I changed to use assets folder in 45a4a02

olivierobert

Some early feedback again

assets/stylesheets/layouts/authentication.scss

assets/stylesheets/app-components.scss

bootstrap/db.go

helpers/to_snake_case.go

controllers/registration.go

assets/stylesheets/screens/index.scss

gutakk

Please add the minimum node version can be used in this project as I cannot use version 10 with this project.

controllers/base.go

gutakk · 2021-01-19T08:28:45Z

controllers/registration.go

+	c.Layout = "layouts/authentication.html"
+	c.TplName = "registration/new.html"
+
+	c.Data["Title"] = "Create a new account"


How about move the Create a new account to const variable as I saw you use this more than one places and also the Layout and TplName

I moved them into a new function

forms/registration.go

gutakk · 2021-01-19T08:31:23Z

forms/registration.go

+func (registrationForm *RegistrationForm) Valid(v *validation.Validation) {
+	if registrationForm.Password != registrationForm.PasswordConfirmation {
+		// Set error messages of Name by SetError and HasErrors will return true
+		err := v.SetError("Password", "Password confirmation does not match")


How about this error message?

Password does not match password confirmation

It a little bit confuse what password confirmation does not match with.

I changed. Actually, we can not say Password confirmation does not match the email or something else, but to avoid your confusion, it should be changed

gutakk · 2021-01-19T08:46:33Z

forms/registration.go

+
+	success, err := valid.Valid(registrationForm)
+	if err != nil {
+		logs.Error("Validation error:", err)


Not sure if this what you expect. When I tried to register with passwords don't match, this printed out to the console

SetError error: Password confirmation does not match

Nothing about Validation error:

This just logs the error when Valid() doesn't work as expected, I don't know when it will raise that error, but the Valid() function returns a success value and an error object, so we have to handle the error

main.go

gutakk · 2021-01-19T08:50:44Z

views/shared/header.html

+      <div class="navigation-menu">
+        <div class="navigation-menu__left">
+          <a class="navigation-menu__logo" href="/">
+            <img src="/static/images/logo.svg" alt="Go Scraper" />


How about use background-image for this. You can find more information here. cc @olivierobert

I changed to use the background-image, will research about the SVG inline later

gutakk · 2021-01-19T08:52:51Z

This error message is not user friendly after I tried to register with duplicate email.

assets/stylesheets/layouts/_authentication.scss

assets/stylesheets/components/_header.scss

olivierobert reviewed Dec 18, 2020

View reviewed changes

hoangmirs force-pushed the chore/setup-ci-cd branch from ebbaaa1 to 111fb1e Compare December 18, 2020 08:07

Base automatically changed from chore/setup-ci-cd to development December 18, 2020 08:13

hoangmirs added 9 commits December 18, 2020 15:35

Remove NGINX and refactor app builder

076fe49

Support getting httpport from 6970

1635fe0

Split CSS to improve build time on development

485c948

Config DB and models

05b8ad4

Add authentication layout

1a05d9e

Update to work with v2

9bce34c

Add favicon to layouts

d1438c3

Add form UI

037d709

[WIP] Add header style

b30d6e7

hoangmirs force-pushed the feature/registration-page branch from a832eac to b30d6e7 Compare December 21, 2020 13:53

hoangmirs added 5 commits December 22, 2020 17:45

Add header style

2c8cfbb

Create account and save to DB

6721920

Add previous form data to view

cfb4a30

Fix issues detected by linter

7da2e00

Add orm debug on dev

fef846b

olivierobert reviewed Dec 29, 2020

View reviewed changes

hoangmirs added 2 commits January 4, 2021 11:14

Rename to_snake_case helper to text

7b57cbe

Rename userForm to registrationForm

b82f6f4

hoangmirs self-assigned this Jan 6, 2021

hoangmirs added the type : feature label Jan 6, 2021

hoangmirs added this to In progress in Version 1.0.0 via automation Jan 6, 2021

hoangmirs added this to the 1.0.0 milestone Jan 6, 2021

hoangmirs linked an issue Jan 6, 2021 that may be closed by this pull request

As a guest, I can register #2

Closed

7 tasks

hoangmirs changed the title ~~[WIP] As a guest, I can register~~ As a guest, I can register Jan 6, 2021

hoangmirs marked this pull request as ready for review January 6, 2021 04:11

hoangmirs requested a review from Lahphim January 6, 2021 04:12

Lahphim reviewed Jan 6, 2021

View reviewed changes

assets/stylesheets/screens/index.scss Outdated Show resolved Hide resolved

hoangmirs requested review from junan and gutakk January 19, 2021 03:47

Refactor password helper

9eddc2a

gutakk reviewed Jan 19, 2021

View reviewed changes

gutakk mentioned this pull request Jan 19, 2021

As a guest, I can register - Testing #26

Merged

hoangmirs added 9 commits January 19, 2021 17:50

Refactor stylesheets folder

2bc078e

Change import order

cfb9c54

Add some default error messages

1f6952a

Add xsrfdata to form

d2298f2

Refactor form

6077a17

Update README to require Node latest LTS version

578b25f

Change to use background-image for logo

b63d12b

Change password not match message

f983878

Add file-loader to load images

d3dd915

Lahphim reviewed Jan 20, 2021

View reviewed changes

assets/stylesheets/layouts/_authentication.scss Show resolved Hide resolved

Remove some redundant spaces

d9052d5

Version 1.0.0 automation moved this from Review in progress to Reviewer approved Jan 20, 2021

Lahphim approved these changes Jan 20, 2021

View reviewed changes

Split media queries

e82165c

gutakk approved these changes Jan 21, 2021

View reviewed changes

olivierobert reviewed Jan 22, 2021

View reviewed changes

assets/stylesheets/components/_header.scss Outdated Show resolved Hide resolved

hoangmirs added 4 commits January 22, 2021 16:46

Fix stylesheet classes

2b9d7e9

Add assets as static path

45a4a02

Remove redundant check

a217c0f

Remove redundant import

1b5fa93

olivierobert approved these changes Jan 25, 2021

View reviewed changes

hoangmirs merged commit 95d1b82 into development Jan 28, 2021

Version 1.0.0 automation moved this from Reviewer approved to Done Jan 28, 2021

hoangmirs deleted the feature/registration-page branch January 28, 2021 04:10

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

As a guest, I can register #23

As a guest, I can register #23

hoangmirs commented Dec 17, 2020 •

edited

olivierobert left a comment

olivierobert Dec 18, 2020

hoangmirs Dec 29, 2020

olivierobert Jan 22, 2021

hoangmirs Jan 22, 2021

olivierobert left a comment

gutakk left a comment

gutakk Jan 19, 2021

hoangmirs Jan 20, 2021

gutakk Jan 19, 2021

hoangmirs Jan 20, 2021

gutakk Jan 19, 2021

hoangmirs Jan 20, 2021

gutakk Jan 19, 2021

hoangmirs Jan 20, 2021

gutakk commented Jan 19, 2021

As a guest, I can register #23

As a guest, I can register #23

Conversation

hoangmirs commented Dec 17, 2020 • edited

What happened 👀

Insight 📝

Proof Of Work 📹

olivierobert left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

olivierobert left a comment

Choose a reason for hiding this comment

gutakk left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

gutakk commented Jan 19, 2021

hoangmirs commented Dec 17, 2020 •

edited