RDCC-2722: Upgrading Spring Version to 2.4.5 & other dependency versions #1038
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AdilHMCTS
changed the title
kavithagade12
previously approved these changes
May 4, 2021
src/main/java/uk/gov/hmcts/reform/professionalapi/controller/request/UserCreationRequest.java
Outdated
Show resolved
Hide resolved
abhijitdiwan
reviewed
May 5, 2021
| - name: professional-api-POSTGRES-PASS | ||
| alias: spring.datasource.password | ||
| - name: ApplicationInsightsInstrumentationKey | ||
| alias: azure.application-insights.instrumentation-key |
There was a problem hiding this comment.
do we need alias mandatory?
There was a problem hiding this comment.
Yes, this will replace the use of bootstrap.yaml - I verified this with @vijayrajagopalan-hmcts
abhijitdiwan
reviewed
May 5, 2021
src/main/java/uk/gov/hmcts/reform/professionalapi/util/RefDataUtil.java
Outdated
Show resolved
Hide resolved
abhijitdiwan
previously approved these changes
May 5, 2021
shreedhar-hmcts
previously approved these changes
May 5, 2021
SujeethKumarAri
previously approved these changes
May 5, 2021
…rieve pbs by email
…rieve pbs by email
# Conflicts: # src/functionalTest/java/uk/gov/hmcts/reform/professionalapi/ProfessionalExternalUserFunctionalTest.java
rajkatla-hmcts
dismissed stale reviews from SujeethKumarAri, shreedhar-hmcts, and abhijitdiwan
via
18f33e6
…into RDCC-2722 � Conflicts: � src/functionalTest/java/uk/gov/hmcts/reform/professionalapi/ProfessionalExternalUserFunctionalTest.java
SujeethKumarAri
approved these changes
May 27, 2021
ishratt
approved these changes
May 27, 2021
shreedhar-hmcts
approved these changes
May 27, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA link (if applicable)
https://tools.hmcts.net/jira/browse/RDCC-2722
Change description
Upgrading Spring Version to 2.4.5 & other dependency versions
Does this PR introduce a breaking change? (check one with "x")