Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependency pug to v3.0.1 [SECURITY] #72

Merged
merged 1 commit into from Mar 17, 2021

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Mar 3, 2021

WhiteSource Renovate

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
pug (source) 3.0.0 -> 3.0.1 age adoption passing confidence

GitHub Vulnerability Alerts

CVE-2021-21353

Impact

If a remote attacker was able to control the pretty option of the pug compiler, e.g. if you spread a user provided object such as the query parameters of a request into the pug template inputs, it was possible for them to achieve remote code execution on the node.js backend.

Patches

Upgrade to pug@3.0.1 or pug-code-gen@3.0.2 or pug-code-gen@2.0.3, which correctly sanitise the parameter.

Workarounds

If there is no way for un-trusted input to be passed to pug as the pretty option, e.g. if you compile templates in advance before applying user input to them, you do not need to upgrade.

References

Original report: pugjs/pug#3312

For more information

If you believe you have found other vulnerabilities, please DO NOT open an issue. Instead, you can follow the instructions in our Security Policy


Release Notes

pugjs/pug

v3.0.1

Compare Source

Bug Fixes

  • Sanitise the pretty option (#​3314)

    If a malicious attacker could control the pretty option, it was possible for them to achieve remote code execution on the server rendering the template. All pug users should upgrade as soon as possible, see #​3312 for more details.


Renovate configuration

📅 Schedule: "" (UTC).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

♻️ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by WhiteSource Renovate. View repository job log here.

@renovate renovate bot added the dependencies Pull requests that update a dependency file label Mar 3, 2021
@hmcts-jenkins-cnp hmcts-jenkins-cnp bot temporarily deployed to preview March 3, 2021 03:37 Inactive
@hmcts-jenkins-cnp hmcts-jenkins-cnp bot requested a deployment to preview March 3, 2021 13:12 Abandoned
@hmcts-jenkins-cnp hmcts-jenkins-cnp bot temporarily deployed to preview March 8, 2021 13:42 Inactive
@renovate renovate bot force-pushed the renovate/npm-pug-vulnerability branch from 317a96d to eed9843 Compare March 8, 2021 23:27
@hmcts-jenkins-cnp hmcts-jenkins-cnp bot temporarily deployed to preview March 8, 2021 23:33 Inactive
@sonarcloud
Copy link

sonarcloud bot commented Mar 9, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@hmcts-jenkins-cnp hmcts-jenkins-cnp bot requested a deployment to preview March 9, 2021 13:16 Abandoned
@adusumillipraveen adusumillipraveen merged commit 65ec8ba into master Mar 17, 2021
@adusumillipraveen adusumillipraveen deleted the renovate/npm-pug-vulnerability branch March 17, 2021 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file ns:cnp prd:plum
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants