Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependency follow-redirects to v1.15.6 [SECURITY] #601

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Jan 11, 2024

Mend Renovate

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
follow-redirects 1.15.5 -> 1.15.6 age adoption passing confidence

GitHub Vulnerability Alerts

CVE-2024-28849

When using axios, its dependency follow-redirects only clears authorization header during cross-domain redirect, but allows the proxy-authentication header which contains credentials too.

Steps To Reproduce & PoC

Test code:

const axios = require('axios');

axios.get('http://127.0.0.1:10081/', {
 headers: {
 'AuThorization': 'Rear Test',
 'ProXy-AuthoriZation': 'Rear Test',
 'coOkie': 't=1'
 }
})
 .then((response) => {
 console.log(response);
 })

When I meet the cross-domain redirect, the sensitive headers like authorization and cookie are cleared, but proxy-authentication header is kept.

Impact

This vulnerability may lead to credentials leak.

Recommendations

Remove proxy-authentication header during cross-domain redirect

Recommended Patch

follow-redirects/index.js:464

- removeMatchingHeaders(/^(?:authorization|cookie)$/i, this._options.headers);
+ removeMatchingHeaders(/^(?:authorization|proxy-authorization|cookie)$/i, this._options.headers);

Release Notes

follow-redirects/follow-redirects (follow-redirects)

v1.15.6

Compare Source


Configuration

📅 Schedule: Branch creation - "" in timezone Europe/London, Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by Mend Renovate. View repository job log here.

@renovate renovate bot force-pushed the renovate/npm-follow-redirects-vulnerability branch from ecf8e86 to 972ddca Compare January 31, 2024 12:25
@renovate renovate bot force-pushed the renovate/npm-follow-redirects-vulnerability branch from 972ddca to bff30e6 Compare February 7, 2024 16:00
@renovate renovate bot force-pushed the renovate/npm-follow-redirects-vulnerability branch from bff30e6 to 0b295ac Compare February 26, 2024 15:31
@renovate renovate bot changed the title Update dependency follow-redirects to v1.15.4 [SECURITY] Update dependency follow-redirects to v1.15.6 [SECURITY] Mar 16, 2024
@renovate renovate bot force-pushed the renovate/npm-follow-redirects-vulnerability branch from 0b295ac to 1389954 Compare March 16, 2024 20:21
@renovate renovate bot force-pushed the renovate/npm-follow-redirects-vulnerability branch from 1389954 to bc4f177 Compare March 19, 2024 11:17
@renovate renovate bot force-pushed the renovate/npm-follow-redirects-vulnerability branch from bc4f177 to fdd1aae Compare March 25, 2024 22:29
@renovate renovate bot force-pushed the renovate/npm-follow-redirects-vulnerability branch from fdd1aae to dfec699 Compare March 26, 2024 01:21
@renovate renovate bot force-pushed the renovate/npm-follow-redirects-vulnerability branch from dfec699 to 192f4d8 Compare March 28, 2024 02:17
@renovate renovate bot force-pushed the renovate/npm-follow-redirects-vulnerability branch from 192f4d8 to ba392d0 Compare April 3, 2024 15:02
@renovate renovate bot force-pushed the renovate/npm-follow-redirects-vulnerability branch 2 times, most recently from cbe6438 to b076308 Compare April 9, 2024 23:44
@renovate renovate bot force-pushed the renovate/npm-follow-redirects-vulnerability branch 2 times, most recently from ef5c030 to ed2c790 Compare April 25, 2024 10:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

0 participants