DTSAM-290 rm Recorder Salaried #1916
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hmcts-jenkins-a-to-c
bot
added
ns:am
prd:am
rel:am-org-role-mapping-service-pr-1916
labels
mikebrownccd
reviewed
Jun 4, 2024
infrastructure/main.tf
Outdated
| @@ -107,6 +107,7 @@ module "org-role-mapping-database-v15" { | |||
| component = var.component | |||
| common_tags = var.common_tags | |||
| pgsql_version = "15" | |||
| pgsql_sku = var.pgsql_sku | |||
There was a problem hiding this comment.
Should this change be in this PR?
There was a problem hiding this comment.
i think it’s because the inner branches are out of sync with master, where as this branch is in sync - so its showing more differences. will update the inner branches to match master, when siva resolves the fta pipeline issues 👍
infrastructure/variables.tf
Outdated
| @@ -80,4 +80,9 @@ variable "kv_subscription" { | |||
| default = "DCD-CNP-DEV" | |||
| type = string | |||
| description = "Update this with the name of the subscription where the single server key vault is. Defaults to DCD-CNP-DEV." | |||
| } | |||
There was a problem hiding this comment.
Should this change be in this PR?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira link (if applicable)
https://tools.hmcts.net/jira/browse/DTSAM-290
Change description
Removing
Recorder Salariedfrom DTSAM-290 #1906