Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DTSAM-234 Addition of ticket code check to tribunal judge fee paid #1796

Open
wants to merge 18 commits into
base: master
Choose a base branch
from

Conversation

anthonydummer
Copy link
Contributor

@anthonydummer anthonydummer commented Feb 28, 2024

Jira link (if applicable)

COT-801 / DTSAM-234 "SSCS Judicial Bookings: Add the TicketCode == 368 filter to the Has-Booking role-assignment config to match the Bookable role-assignment config"

Change description

Addition of ticket check to the Tribunal Fee Paid role.

NB: We will need confirmation from the service when it is OK to merge this as they are currently testing in PREVIEW. And this PR will enable in PREVIEW by default

Checklist

  • commit messages are meaningful and follow good commit message guidelines
  • Does this PR introduce a breaking change

mattnayler
mattnayler previously approved these changes Feb 29, 2024
Copy link
Contributor

@mattnayler mattnayler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

mikebrownccd
mikebrownccd previously approved these changes Feb 29, 2024
Copy link
Contributor

@mikebrownccd mikebrownccd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mattnayler mattnayler marked this pull request as ready for review February 29, 2024 15:19
mattnayler
mattnayler previously approved these changes Mar 15, 2024
Copy link
Contributor

@mattnayler mattnayler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

mikebrownccd
mikebrownccd previously approved these changes Mar 15, 2024
Copy link
Contributor

@mikebrownccd mikebrownccd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mattnayler mattnayler added the DO NOT MERGE DO NOT MERGE this PR. label Mar 15, 2024
@abul-syed abul-syed marked this pull request as draft May 9, 2024 09:25
# Conflicts:
#	src/main/java/uk/gov/hmcts/reform/orgrolemapping/domain/model/enums/FeatureFlagEnum.java
#	src/test/java/uk/gov/hmcts/reform/orgrolemapping/domain/service/DroolSscsJudicialRoleMappingTest.java
@abul-syed abul-syed marked this pull request as ready for review May 9, 2024 11:46
Copy link
Contributor

@mikebrownccd mikebrownccd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@mattnayler mattnayler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mattnayler mattnayler changed the title COT-801 Addition of ticket code check to tribunal judge fee paid DTSAM-234 Addition of ticket code check to tribunal judge fee paid May 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DO NOT MERGE DO NOT MERGE this PR. enable_keep_helm Do not uninstall helm release after pipeline completion ns:am prd:am rel:am-org-role-mapping-service-pr-1796
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants