Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ga 166 prm clean up process #1780

Open
wants to merge 12 commits into
base: GA_PRM_Master
Choose a base branch
from

Conversation

sanjayparekh-hmcts
Copy link

Jira link (if applicable)

https://tools.hmcts.net/jira/browse/GA-166

Change description

Checklist

  • commit messages are meaningful and follow good commit message guidelines
  • README and other documentation has been updated / added (if needed)
  • tests have been updated / new tests has been added (if needed)
  • Does this PR introduce a breaking change

@hmcts-jenkins-a-to-c
Copy link
Contributor

hmcts-jenkins-a-to-c bot commented Mar 1, 2024

Plan Result

⚠️ Resource Deletion will happen ⚠️

This plan contains resource delete operation. Please check the plan result very carefully!

Plan: 1 to add, 0 to change, 3 to destroy.
  • Delete
    • azurerm_key_vault_secret.POSTGRES-USER
    • module.org-role-mapping-database-v15.null_resource.set-schema-ownership["org_role_mapping"]
  • Replace
    • module.org-role-mapping-database-v15.null_resource.set-user-permissions-additionaldbs["org_role_mapping"]
Change Result (Click me)
  # azurerm_key_vault_secret.POSTGRES-USER will be destroyed
  # (because azurerm_key_vault_secret.POSTGRES-USER is not in configuration)
  - resource "azurerm_key_vault_secret" "POSTGRES-USER" {
      - id                      = "https://am-aat.vault.azure.net/secrets/org-role-mapping-service-POSTGRES-USER/2f8a84fc34184afa9f4d6990788c9736" -> null
      - key_vault_id            = "/subscriptions/1c4f0704-a29e-403d-b719-b90c34ef14c9/resourceGroups/am-shared-infrastructure-aat/providers/Microsoft.KeyVault/vaults/am-aat" -> null
      - name                    = "org-role-mapping-service-POSTGRES-USER" -> null
      - resource_id             = "/subscriptions/1c4f0704-a29e-403d-b719-b90c34ef14c9/resourceGroups/am-shared-infrastructure-aat/providers/Microsoft.KeyVault/vaults/am-aat/secrets/org-role-mapping-service-POSTGRES-USER/versions/2f8a84fc34184afa9f4d6990788c9736" -> null
      - resource_versionless_id = "/subscriptions/1c4f0704-a29e-403d-b719-b90c34ef14c9/resourceGroups/am-shared-infrastructure-aat/providers/Microsoft.KeyVault/vaults/am-aat/secrets/org-role-mapping-service-POSTGRES-USER" -> null
      - tags                    = {} -> null
      - value                   = (sensitive value) -> null
      - version                 = "2f8a84fc34184afa9f4d6990788c9736" -> null
      - versionless_id          = "https://am-aat.vault.azure.net/secrets/org-role-mapping-service-POSTGRES-USER" -> null
    }

  # module.org-role-mapping-database-v15.null_resource.set-schema-ownership["org_role_mapping"] will be destroyed
  # (because key ["org_role_mapping"] is not in for_each map)
  - resource "null_resource" "set-schema-ownership" {
      - id       = "856843227819443011" -> null
      - triggers = {
          - "force_trigger" = "3"
          - "name"          = "am-org-role-mapping-service-postgres-db-v15"
          - "script_hash"   = "ab1645969422eb52f19784fd29e26fd044ec09acb082bf6000c500468232933e"
        } -> null
    }

  # module.org-role-mapping-database-v15.null_resource.set-user-permissions-additionaldbs["org_role_mapping"] must be replaced
-/+ resource "null_resource" "set-user-permissions-additionaldbs" {
      ~ id       = "8532968316779169756" -> (known after apply)
      ~ triggers = { # forces replacement
          ~ "force_trigger"  = "3" -> "1"
            # (3 unchanged elements hidden)
        }
    }

Plan: 1 to add, 0 to change, 3 to destroy.

@hmcts-jenkins-a-to-c hmcts-jenkins-a-to-c bot requested a deployment to preview March 4, 2024 15:52 Abandoned
Copy link

@shaed-parkar shaed-parkar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. It might be worth tracking the start and stop events even if we don't have alerts defined for it yet just to monitor manually and aid with testing

…NumberOfDays and deleteActiveOrganisationRefreshQueueEntitiesLastUpdatedBeforeNumberOfDays
…NumberOfDays and deleteActiveOrganisationRefreshQueueEntitiesLastUpdatedBeforeNumberOfDays

add an additional scenario for the clean up job
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants