Add Red language highlighting #988

Oldes · 2015-11-20T08:34:24Z

…ords

…ache code detection

Oldes · 2015-11-20T09:29:26Z

Ok... to resolve detection conflict with Apache was quite easy, but what a hack, how I can resolve conflict with something like Inform 7 !? Please help!

… language.

Oldes · 2015-11-20T10:02:01Z

Fine.. Red language does not allow comma after alpha chars, so this conflict is fixed too.. but how to solve conflict between vhdl and Inform7 now? Crazy.

…ict with VHDL

…ict with gams

Sannis · 2015-11-20T10:42:11Z

src/languages/inform7.js

@@ -37,6 +37,7 @@ function(hljs) {
      },
      {
        className: 'section',
+        relevance: 8,


We usually try to avoid very precise relevance boosters. If this required, just use 10.

I used 10 in the commit above, but than I had conflict with Gems.

…atica and removing common category.

Oldes · 2015-11-20T11:25:11Z

Sorry for so many commits, I was not able to install the test suite locally because of some dependency reasons.

…t to eat spaces in front of it (shame there is not a look-back chance)

isagalaev · 2015-11-20T17:54:20Z

Resolving detection conflicts is a sort of an art in itself :-) It's best done by creating more specific contexts, rather than fiddling with relevance values. You can leave it as is for now, I'll try to have a look some time next week.

The dependency problem may be due to the fact that we use node 4.x since recently.

Oldes · 2015-11-22T18:55:03Z

@isagalaev Sorry that I ask, it is my first time I use node.js, but trying to run the test locally and not to pollute it here with every little change, I have this error:

> highlight.js@8.9.1 test /Users/oldes/GIT/highlight.js
> mocha test/

module.js:339
    throw err;
    ^

Error: Cannot find module '../../build'
    at Function.Module._resolveFilename (module.js:337:15)
    at Function.Module._load (module.js:287:25)
    at Module.require (module.js:366:17)
    at require (module.js:385:17)
    at Object.<anonymous> (/Users/oldes/GIT/highlight.js/test/api/ident.js:3:12)
    at Module._compile (module.js:435:26)
    at Object.Module._extensions..js (module.js:442:10)
    at Module.load (module.js:356:32)
    at Function.Module._load (module.js:311:12)
    at Module.require (module.js:366:17)
    at require (module.js:385:17)
    at Suite.<anonymous> (/Users/oldes/GIT/highlight.js/test/api/index.js:4:3)
    at context.describe.context.context (/Users/oldes/GIT/highlight.js/node_modules/mocha/lib/interfaces/bdd.js:47:10)
    at Object.<anonymous> (/Users/oldes/GIT/highlight.js/test/api/index.js:3:1)
    at Module._compile (module.js:435:26)
    at Object.Module._extensions..js (module.js:442:10)
    at Module.load (module.js:356:32)
    at Function.Module._load (module.js:311:12)
    at Module.require (module.js:366:17)
    at require (module.js:385:17)
    at Object.<anonymous> (/Users/oldes/GIT/highlight.js/test/index.js:5:1)
    at Module._compile (module.js:435:26)
    at Object.Module._extensions..js (module.js:442:10)
    at Module.load (module.js:356:32)
    at Function.Module._load (module.js:311:12)
    at Module.require (module.js:366:17)
    at require (module.js:385:17)
    at /Users/oldes/GIT/highlight.js/node_modules/mocha/lib/mocha.js:216:27
    at Array.forEach (native)
    at Mocha.loadFiles (/Users/oldes/GIT/highlight.js/node_modules/mocha/lib/mocha.js:213:14)
    at Mocha.run (/Users/oldes/GIT/highlight.js/node_modules/mocha/lib/mocha.js:453:10)
    at Object.<anonymous> (/Users/oldes/GIT/highlight.js/node_modules/mocha/bin/_mocha:393:18)
    at Module._compile (module.js:435:26)
    at Object.Module._extensions..js (module.js:442:10)
    at Module.load (module.js:356:32)
    at Function.Module._load (module.js:311:12)
    at Function.Module.runMain (module.js:467:10)
    at startup (node.js:136:18)
    at node.js:963:3
npm ERR! Test failed.  See above for more details.

I have Node v4.2.2 on MacOS. Any idea what is wrong? Also I had these warning on npm install

npm WARN unmet dependency /Users/oldes/GIT/highlight.js/node_modules/del/node_modules/globby requires glob@'^5.0.3' but will load
npm WARN unmet dependency /Users/oldes/GIT/highlight.js/node_modules/glob,
npm WARN unmet dependency which is version 6.0.1
npm WARN unmet dependency /Users/oldes/GIT/highlight.js/node_modules/del/node_modules/rimraf requires glob@'^5.0.14' but will load
npm WARN unmet dependency /Users/oldes/GIT/highlight.js/node_modules/glob,
npm WARN unmet dependency which is version 6.0.1

…nstead of Asciidoc in small code samples.

…nproto

Oldes · 2015-11-22T20:20:22Z

@isagalaev forget my building question above.. I found that I must do build for node, not just the default one for browser.. so now I can save some invalid commits as a part of language detection part:)

…ection without conflicts in tests and adding description

…not ordinary words (some'thing) handling. Included category: functional csp: increased relevance for single quota strings, so it takes precedence over Red language in autodetection

mydigitalself · 2017-04-24T08:29:00Z

Is there any update on this? Would love to support Red in Gitter.

https://gitter.im/gitterHQ/gitter?at=58f8f9cc8e4b63533de9d32b

isagalaev · 2017-05-31T02:03:34Z

Tried to merge it today but there's quite a lot of little thing here and there that needed to be fixed for this definition to play well with each other. I understand it's been a while, so I have to ask if anyone (original author or not) is still interested in getting this done, I'd make a full review on it.

ghost · 2017-06-04T15:22:57Z

Not the original author, but we all will be glad if you review it. And I am sure even @Oldes is interested in getting it done.

isagalaev · 2017-06-05T04:09:06Z

Cool! The best way to do it then is for someone to fork this branch and create a new PR with it so we could actually make changes. I'm not familiar with Red at all to do anything on my own :-)

Oldes · 2017-06-05T15:10:04Z

Hi @isagalaev thank you for your interest.. I will make a new clean PR and will let you know here.

isagalaev · 2017-06-08T05:33:14Z

@Oldes thanks! I looked through the history of this ticket and only now see that we actually tried to review it before :-)

If you're going to make a fresh one, pleasen ignore language detection problems on the first go and don't tune relevance. We'll deal with it after the code is in the correct shape.

joshgoebel · 2019-12-24T07:55:47Z

I was mainly building the version for browser so I could see how it looks like, was not expecting, that for node I must build it again.

Yeah, this is annoying. But I don't hit it often enough to figure out how to best fix it. We could have separate build directories for each or always use the subfolders (like when you do a build all).

joshgoebel · 2019-12-24T07:56:53Z

@Oldes

First of all, truly sorry for the long delay in processing this PR.

Thank you so much for desiring to contribute and writing a language grammar. Unfortunately, we currently are no longer accepting new languages into the core repository. The existing maintainers simply don't have time to maintain new languages (fixing bugs, dealing with issues, etc). We'd still love to host your language as a 3rd party module though - if you're willing to help maintain it.

It's easy to turn your language into a module that anyone who likes can easily integrate with Highlight.js using a single line of code:

<script src="/path/to/highlight.min.js"></script>
<!-- they'd simply add your language modules -->
<script src="/path/to/highlightjs-red-lang.js"></script> 
<script>hljs.initHighlightingOnLoad();</script>

It's also possible for users to rebuild the highlight.js library to include specific 3rd party modules, all in a single file (vs loading a bunch of 3rd party languages one at a time).

If you'd like to become the maintainer for this language then we're happy to create a new repository in the highlightjs organization and host the repository there. That assumes you'd be open to reviewing issues and fixing bugs as they arise. You're also welcome to host the repo yourself and we'll link to it from our README.

There isn't much in the way of how to docs on this yet, but there are sample repositories and it's honestly pretty easy. We're still fleshing out an official "spec" for 3rd party modules, but even after that's done it should require minimal changes from the examples we have already. IE, if you wanted to get started now there isn't any big reason to wait.

My own robots.txt grammar repository is a great, simple example:

https://github.com/highlightjs/highlightjs-robots-txt

If you have any questions feel free to ask.

joshgoebel · 2020-01-02T01:21:47Z

Closing for inactivity; (also finally cleaning all these old PRs out for the new year).

As mentioned above if you're interested in becoming the maintainer of a 3rd party module, please respond [whenever you find time] and we'd be happy to help you get started.

Oldes · 2020-11-15T20:54:26Z

@joshgoebel Hi Josh... so I'm back again and ready to create a 3rd party module... what I should do? Should I host it under my account? Or you will set up a repo for me? I would really want to have colorizer for Red language (and Rebol) available under Gitter and this is the only path.

joshgoebel · 2020-11-16T01:16:40Z

Does Gitter let you control the JS/HTML and inject your own code?

https://github.com/highlightjs/highlight.js/blob/master/extra/3RD_PARTY_QUICK_START.md

Should I host it under my account? Or you will set up a repo for me?

Your choice. We can make a repo here or you can have it under your own account.

Oldes · 2020-11-16T07:34:51Z

No... I think that no one sane enough would allow JS injection... but Gitter is using Highlight.js, so the only way how to get our code colorized there is adding support for the language into oficial repository somehow.

I was reading the 3RD_PARTY_QUICK_START.md document, but it is not too clear to me...

if I will add syntax under my repo, how it can be found by anyone else than me? Like the Gitter, for example.
there is mention of src/languages/name.js, but the linked examples have the syntax only in src/
the document talks about putting the files under the extra/ folder, but the repository would be elsewhere... like the 2 examples from document.

If it's not possible to use 3rd_party module by 4th_party user (Gitter), than it does not make much sense... because to build version for my personal purposes, I can easily put the files under normal structure, how I was doing it 5 years ago :-/

joshgoebel · 2020-11-16T08:05:20Z

No... I think that no one sane enough would allow JS injection...

Many hosted services do. If they allowed you to add your own HTML/CSS/theme then you can typically add JS just be adding script tags, etc... this is a common way to customize many sites. I just learned the other day you can add 3rd party languages to Discourse via this type of functionality.

Gitter is using Highlight.js, so the only way how to get our code colorized there is adding support for the language into oficial repository somehow.

This indicates is a pretty large misunderstanding. The way to get your code colorized on Gitter is to get Gitter to care about your language, period. If they don't, you won't. If they do, you might. Getting your language into our core library alone means nothing. Gitter seems to use only ~70 languages or so... we support 190... Very often services that use our library (Gitter, Discord, StackOverflow, etc) purposely only use a fraction of the languages (for various reasons). Just getting your favorite language added upstream does not magically make it work anywhere that uses Highlight.js.

Highlight.js (at it's core) is just a highlighting engine - that comes bundled with 190 languages you can potentially use. It's possible to use it and use only a single grammar - just because someone is using Highlight.js doesn't mean they highlight every single language that we provide with the core library.

if I will add syntax under my repo, how it can be found by anyone else than me? Like the Gitter, for example.

We'd add it to the official list of supported languages - so anyone looking would know it exists. They'd have to decide to install support for it - just like they do with their existing 70 languages out of a much larger # of possible languages they could support.

there is mention of src/languages/name.js, but the linked examples have the syntax only in src/

It can be made to work different ways. src/languages is more preferred.

the document talks about putting the files under the extra/ folder, but the repository would be elsewhere... like the 2 examples from document.

To build along side the core library you would checkout your repository into the extras folder. That allows the existing build scripts to magically build your grammar along side (or into) the main library.

If it's not possible to use 3rd_party module by 4th_party user (Gitter), than it does not make much sense...

Anyone who chooses can use 3rd party modules. We make that easy to do, but services have to decide which languages to support. This is true whether the language is 1st or 3rd party. Typically getting large services to add language support for languages that aren't super popular is an uphill battle though.

because to build version for my personal purposes, I can easily put the files under normal structure, how I was doing it 5 years ago :-/

Yes, but if you care about anyone in the broader community (of millions of users) being able to easily use your grammar then you'd really want to publish it as a 3rd party module - so that they could drop it into their projects with only a single line of code.

Oldes · 2020-11-16T09:12:13Z

I'm not expecting the support to appear somewhere automatically.. I was asking on Gitter chat about it: https://gitter.im/gitter/gitter?at=5fb16c92f2fd4f60fc7637de

Oldes · 2020-11-16T09:14:49Z

I just simply does not understand why you decided to go this strange 3rd party way... why you just don't allow to build specific set of languages on demand and have these languages in the main repo... I simply don't understand how is this more user friendly?

joshgoebel · 2020-11-16T09:24:34Z

Context:
#2149

No one ever said it’s more user-friendly. It takes a lot of time and effort to support and maintain or add languages to the core library. It’s time that the current maintainers simply don’t have. We are barely keeping up with existing and popular languages as it is.

So we made it possible and easy for anyone who wants to create third-party grammar modules that anyone can use with about one line of code.

joshgoebel · 2020-11-16T09:31:53Z

If you’re serious about Gitter I’d suggest making a third-party grammar and then making a pull request against the Gitter markdown stuff to use that grammar and see where that gets you.

Oldes · 2020-11-16T09:39:54Z

I will, but I still don't understand, what are we second-class language users supposed to do to have it registered in h.js :-/
To add a link to my new repo here?

joshgoebel · 2020-11-16T09:41:43Z

https://github.com/highlightjs/highlight.js/blob/master/SUPPORTED_LANGUAGES.md

Oldes · 2020-11-16T09:57:35Z

Ok... that makes sense.. it should be mentioned here: https://github.com/highlightjs/highlight.js/blob/master/extra/3RD_PARTY_QUICK_START.md

So I will make a self hosted repo and than submit PR to add a link into the list.

joshgoebel · 2020-11-16T10:08:21Z

it should be mentioned here:

PR welcome.

Oldes · 2020-11-16T21:06:30Z

@joshgoebel here it is: #2872 --> https://github.com/Oldes/highlightjs-redbol

Oldes · 2020-11-16T23:12:46Z

I also created a simple github pages with Rebol and Red colorized code examples.

Oldes added 3 commits November 20, 2015 09:33

Red language (www.red-lang.org) highlighting.

e4280e4

Red language: better email detection and relaxing possible chars in w…

6fc721d

…ords

Red language: adding more illegals to resolve possible conflict in ap…

d5f190e

…ache code detection

Inform7 - adding text with comma to solve detection conflict with Red…

8fea394

… language.

Oldes added 2 commits November 20, 2015 11:29

Inform7 - increasing relevance of the section keywords to solve confl…

36b1999

…ict with VHDL

Inform7 - decreasing relevance of the section keywords to solve confl…

a8d57a1

…ict with gams

Sannis reviewed Nov 20, 2015
View reviewed changes

Sannis added the new language label Nov 20, 2015

Oldes added 4 commits November 20, 2015 11:44

Red language: adding one more illegal to resolve conflict with Makefile

5134492

Red language: adding one more illegal to resolve conflict with Mathem…

6a42b05

…atica and removing common category.

Red language: adding one more illegal to resolve conflict with Monkey

229bc60

Red language: improving illegal to resolve conflict with RulesLanguage

91705f7

Oldes added 5 commits November 20, 2015 13:16

Red language: adding propper CHAR and TAG type, modifying OPERATOR no…

33c1e5a

…t to eat spaces in front of it (shame there is not a look-back chance)

Red language: fixed TAG type.

b043f77

Red language: moving keyword FOR after FOREACH

239478e

Red language: enhancing CHAR datatype

b976af5

Red language: protecting <= to be a start of valid TAG

cd370b1

Sannis added this to the 9.0 milestone Nov 22, 2015

Oldes added 2 commits November 22, 2015 20:07

Red language: adding some relevance settings to better discover Red i…

0ed258d

…nstead of Asciidoc in small code samples.

Red language: adding another illegal variant to fix conflict with cap…

9d3700f

…nproto

Oldes added 3 commits November 22, 2015 23:19

Red language: fine tuning relevance and illegals for more precise det…

fc92ba1

…ection without conflicts in tests and adding description

Red language: fixing nested multiline string case

19280d0

Red language: improved TAG not to steal 'not-egual' operator.

d6bcbc8

Sannis removed this from the 9.1 milestone Jan 6, 2016

Sannis changed the title ~~Red language (www.red-lang.org) highlighting.~~ Red language (www.red-lang.org) highlighting Mar 28, 2016

Oldes added 2 commits April 20, 2017 21:19

Merge remote-tracking branch 'isagalaev/master' into red-lang

99399d5

Red language: improved date detection, proper keywords detection and …

409b490

…not ordinary words (some'thing) handling. Included category: functional csp: increased relevance for single quota strings, so it takes precedence over Red language in autodetection

joshgoebel added the 3rd_party label Dec 24, 2019

joshgoebel changed the title ~~Red language (www.red-lang.org) highlighting~~ Add Red language highlighting Dec 24, 2019

joshgoebel closed this Jan 2, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add Red language highlighting #988

Add Red language highlighting #988

Oldes commented Nov 20, 2015 •

edited by joshgoebel

Oldes commented Nov 20, 2015

Oldes commented Nov 20, 2015

Sannis Nov 20, 2015

Oldes Nov 20, 2015

Oldes commented Nov 20, 2015

isagalaev commented Nov 20, 2015

Oldes commented Nov 22, 2015

Oldes commented Nov 22, 2015

mydigitalself commented Apr 24, 2017

isagalaev commented May 31, 2017

ghost commented Jun 4, 2017

isagalaev commented Jun 5, 2017 •

edited

Oldes commented Jun 5, 2017

isagalaev commented Jun 8, 2017

joshgoebel commented Dec 24, 2019

joshgoebel commented Dec 24, 2019

joshgoebel commented Jan 2, 2020

Oldes commented Nov 15, 2020

joshgoebel commented Nov 16, 2020 •

edited

Oldes commented Nov 16, 2020 •

edited

joshgoebel commented Nov 16, 2020 •

edited

Oldes commented Nov 16, 2020

Oldes commented Nov 16, 2020

joshgoebel commented Nov 16, 2020 •

edited

joshgoebel commented Nov 16, 2020

Oldes commented Nov 16, 2020

joshgoebel commented Nov 16, 2020

Oldes commented Nov 16, 2020

joshgoebel commented Nov 16, 2020

Oldes commented Nov 16, 2020

Oldes commented Nov 16, 2020

Add Red language highlighting #988

Add Red language highlighting #988

Conversation

Oldes commented Nov 20, 2015 • edited by joshgoebel

Oldes commented Nov 20, 2015

Oldes commented Nov 20, 2015

Sannis Nov 20, 2015

Choose a reason for hiding this comment

Oldes Nov 20, 2015

Choose a reason for hiding this comment

Oldes commented Nov 20, 2015

isagalaev commented Nov 20, 2015

Oldes commented Nov 22, 2015

Oldes commented Nov 22, 2015

mydigitalself commented Apr 24, 2017

isagalaev commented May 31, 2017

ghost commented Jun 4, 2017

isagalaev commented Jun 5, 2017 • edited

Oldes commented Jun 5, 2017

isagalaev commented Jun 8, 2017

joshgoebel commented Dec 24, 2019

joshgoebel commented Dec 24, 2019

joshgoebel commented Jan 2, 2020

Oldes commented Nov 15, 2020

joshgoebel commented Nov 16, 2020 • edited

Oldes commented Nov 16, 2020 • edited

joshgoebel commented Nov 16, 2020 • edited

Oldes commented Nov 16, 2020

Oldes commented Nov 16, 2020

joshgoebel commented Nov 16, 2020 • edited

joshgoebel commented Nov 16, 2020

Oldes commented Nov 16, 2020

joshgoebel commented Nov 16, 2020

Oldes commented Nov 16, 2020

joshgoebel commented Nov 16, 2020

Oldes commented Nov 16, 2020

Oldes commented Nov 16, 2020

Oldes commented Nov 20, 2015 •

edited by joshgoebel

isagalaev commented Jun 5, 2017 •

edited

joshgoebel commented Nov 16, 2020 •

edited

Oldes commented Nov 16, 2020 •

edited

joshgoebel commented Nov 16, 2020 •

edited

joshgoebel commented Nov 16, 2020 •

edited