Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added list of false positiitives #3999

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

akhtarmdsaad
Copy link
Contributor

Issue: (cpp) Keywords followed by parens are treated as built_in
image

Resolves #3980

Changes

Added list of false positives to FUNCTION_DISPATCH

The List:

      /(?!decltype)/,
      /(?!if)/,
      /(?!for)/,
      /(?!switch)/,
      /(?!while)/,
      /(?!alignas)/,
      /(?!alignof)/,
      /(?!asm)/,
      /(?!catch)/,
      /(?!const_cast)/,
      /(?!dynamic_cast)/,
      /(?!noexcept)/,
      /(?!reinterpret_cast)/,
      /(?!sizeof)/,
      /(?!static_assert)/,
      /(?!static_cast)/,
      /(?!typeid)/,
      /(?!requires)/,
      /(?!explicit)/,
      /(?!case)/,
      /(?!delete)/,
      
      // compound operators
      /(?!bitand_eq)/,
      /(?!bitor_eq)/,
      /(?!xor_eq)/,
      /(?!not_eq)/,
      /(?!or_eq)/,
      /(?!and_eq)/,

      // operators
      /(?!and)/,
      /(?!or)/,
      /(?!bitand)/,
      /(?!bitor)/,
      /(?!xor)/,

      // unary operators
      /(?!not)/,
      /(?!compl)/,
      /(?!co_await)/,
      /(?!co_return)/,
      /(?!co_yield)/,
      
      // Reserved types
      /(?!int)/, 
      /(?!char)/, 
      /(?!double)/, 
      /(?!float)/, 
      /(?!bool)/,
      /(?!auto)/,

Before:

image

After:

image

Checklist

  • Added markup tests, or they don't apply here because...
  • Updated the changelog at CHANGES.md

Copy link

Build Size Report

Changes to minified artifacts in /build, after gzip compression.

5 files changed

Total change +551 B

View Changes
file base pr diff
es/languages/arduino.min.js 4.61 KB 4.74 KB +137 B
es/languages/cpp.min.js 2.59 KB 2.73 KB +139 B
highlight.min.js 8.21 KB 8.21 KB -1 B
languages/arduino.min.js 4.61 KB 4.75 KB +137 B
languages/cpp.min.js 2.6 KB 2.73 KB +139 B

/(?!char)/,
/(?!double)/,
/(?!float)/,
/(?!bool)/,

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are these types really working properly?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

图片

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

i think this is already working properly. No need to change anything.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

(cpp) Keywords followed by parens are treated as built_in
2 participants