New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add operator detecting for c/cpp #3964
base: main
Are you sure you want to change the base?
Conversation
When you say symbol do you mean |
Modified according to [this](highlightjs#3964 (comment)).
Fix `FUNCTION_TITLE` not matching defining operator.
Build Size ReportChanges to minified artifacts in 7 files changedTotal change +573 B View Changes
|
I cleaned up the PR a bit to better match our coding standards... but I think the reason this hasn't been done before if the issue with Right now there are a ton of failing markup tests... you'll need to go thru them and see which are operator related (which will simply need to be updated) and which are template related. There is a line (you can uncomment) in the test/markup test code that will just "replace" the test result files with whatever we generate - it can be helpful for updating result files but if you do this please proof all the changes by hand to guarantee they are as expected. |
Nothing is matched according to the tests. Is |
Fix this `=` unable to be matched.
Fix a typo.
Implement it gracefully.
Remove duplicated rules.
So sorry I forgot to push the main file that does the linking... if pull and build it should work now. |
Build Size ReportChanges to minified artifacts in 7 files changedTotal change +731 B View Changes
|
ok I'll deal with those tests |
relevance: 0 | ||
match: FUNCTION_TITLE, | ||
scope: 'title', | ||
keywords: "operator", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You know, a powerful part of hljs is |
FUNCTION_DECLARATION
not matching overloading operator.Changes
OPERATOR
constant and added it somewhere.FUNCTION_DECLARATION
.