Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add (markdown) emphasis escaping #3888

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

Crater44
Copy link

This feature adds the possibility of escaping italic on markdown

Before the only way to write a word with underscore (e.g. SYS_ADMIN) was placing a space after the underscore, now it's possible to escape it with a backslash so it won't trigger the italic feature.

Change

The change consist on combining the actual negative look-ahead for a space with a negative look-behind for a backslash

@joshgoebel
Copy link
Member

Sadly, we cannot use negative look behind yet as that feature is still too newly added to Safari.

@joshgoebel
Copy link
Member

Actually, hold that thought, perhaps it's time to change this policy: #3890

@Crater44
Copy link
Author

Crater44 commented Nov 3, 2023

@joshgoebel great so if my change can be added that would be great to me because I have it patched in one of my projects and is not the best way to have it

@joshgoebel
Copy link
Member

No lookbehind for now as it would be a breaking change... why not just have a single (separate) rule that matches \* but then chooses not to highlight it? Would that hurt anything else?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants