New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
themes: add new felipec theme #3441
Conversation
Please show results of running |
Here are the results. I noticed the tool checks for
|
Also, my theme was using |
I'm not sure it's more "proper". More exact, perhaps. We'd be open to a PR making the tool smarter. It shouldn't have crashed in any case. |
@joshgoebel Well, it is more precise: I've sent a pull request to check for that too: #3449. |
Do I need to add |
I need to find time to pull it up and at least have a quick glance at it... holidays. You haven't been forgotten. Just busy. |
All right. Here's a screenshot if it helps: screenshot. |
Approved, please add CHANGELOG entry? |
Autogenerated with vim-felipec. Signed-off-by: Felipe Contreras <felipe.contreras@gmail.com>
@joshgoebel Done. I followed the steps of BTW. I think my generator might be useful to other theme creators, for example: palette:
red: '#ef8f8f'
blocks:
- - number literal deletion
- color: red Gets converted to: .hljs-number,
.hljs-literal,
.hljs-deletion {
color: #ef8f8f;
} The full YAML code I used to generate my theme is this: felipec.yml. I use HSL instead of hex triplets, but they get automatically converted. |
Thanks. |
* master: (816 commits) (chore) add sideEffects: false to enable tree-shaking in esbuild & others fix(markdown) Handle `***Hello world***` without breaking (highlightjs#3457) (chore) DRY up php grammar just a little enh(php) support CSSCase attribute naming refactor, security issues enh(php) Add support for Attributes fix(java) prevent false variable init on `else` (highlightjs#3455) (ci) min change threshold for size report (highlightjs#3401) (themes) Add `tokyo-night-dark` (highlightjs#3467) enh(llvm) Improve number support, add `char.escape` (highlightjs#3471) (chore) simplify brainfuck grammar fix(brainfuck) fix highlighting of initial ++/-- Minor change to TypeScript types and TypeScript-specific keywords (highlightjs#3466) fix(angelscript) Fix highlighting of int8, int16, int32, int64 (highlightjs#3464) enh(php) named arguments and fix php constants (highlightjs#3459) themes: add new felipec theme (highlightjs#3441) (chore) release 10.4.0 enh(arcade) Add missing keywords for Arcade v1.16 chore(arcade) eslint --fix, explode keywords enh(php) Left and right-side of double colon (highlightjs#3422) ...
Autogenerated with vim-felipec.