Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New intellij-light Theme #3433

Merged
merged 2 commits into from Dec 27, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGES.md
Expand Up @@ -8,6 +8,7 @@ Themes:

- `Default` is now much closer WCAG AA (contrast) (#3402) [Josh Goebel]
- `Dark` now meets WCAG AA (contrast) (#3402) [Josh Goebel]
- Added `intellij-light` theme [Pegasis]

These changes should be for the better and should not be super noticeable but if you're super picky about your colors you may want to intervene here or copy over the older themes from 11.3 or prior.

Expand Down Expand Up @@ -52,6 +53,7 @@ Themes:

- Modified background color in css for Gradient Light and Gradient Dark themes [Samia Ali][]

[Pegasis]: https://github.com/PegasisForever
[Wojciech Kania]: https://github.com/wkania
[Jeylani B]: https://github.com/jeyllani
[Richard Gibson]: https://github.com/gibson042
Expand Down
119 changes: 119 additions & 0 deletions src/styles/intellij-light.css
@@ -0,0 +1,119 @@
/*

Intellij-light style (c) Pegasis <me@pegasis.site>

*/

.hljs {
color: #000;
background: #fff;
}

.hljs-subst,
.hljs-title {
font-weight: normal;
color: #000;
}

.hljs-title.function_ {
color: #7A7A43;
}

.hljs-code,
.hljs-comment,
.hljs-quote {
color: #8C8C8C;
font-style: italic;
}

.hljs-meta {
color: #9E880D;
}

.hljs-section {
color: #871094;
}

.hljs-variable.language_,
.hljs-symbol,
.hljs-selector-class,
.hljs-selector-id,
.hljs-selector-tag,
.hljs-template-tag,
.hljs-selector-attr,
.hljs-selector-pseudo,
.hljs-keyword,
.hljs-meta .hljs-keyword,
.hljs-literal,
.hljs-name,
.hljs-built_in,
.hljs-type {
color: #0033B3;
}

.hljs-property,
.hljs-attr {
color: #871094;
}

.hljs-attribute {
color: #174AD4;
}

.hljs-number {
color: #1750EB;
}

.hljs-regexp {
color: #264EFF;
}

.hljs-link {
text-decoration: underline;
color: #006DCC;
}

.hljs-meta .hljs-string,
.hljs-string {
color: #067D17;
}

.hljs-char.escape_ {
color: #0037A6;
}

.hljs-doctag {
text-decoration: underline;
}

.hljs-template-variable {
color: #248F8F;
}

.hljs-addition {
background: #BEE6BE;
}

.hljs-deletion {
background: #D6D6D6;
}

.hljs-emphasis {
font-style: italic;
}

.hljs-strong {
font-weight: bold;
}

.hljs-variable,
.hljs-operator,
.hljs-punctuation,
.hljs-title.class_.inherited__,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're intentionally choosing to ignore class names?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes because in intellij light these class names use the default black style.

.hljs-title.class_,
.hljs-params,
.hljs-bullet,
.hljs-formula,
.hljs-tag {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please show a snap of this highlighting XML or HTML... tag is usually pretty important...

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't tag just the part around the tag (*<* div *>*)? The div inside it has class name hljs-name so it will get highlighted. The < and > around the tag uses default styling in intellij-light.
image

/* purposely ignored */
}
1 change: 1 addition & 0 deletions tools/developer.html
Expand Up @@ -107,6 +107,7 @@ <h3>Code</h3>
<option>tomorrow-night-blue.css</option>
<option>monokai.css</option>
<option>idea.css</option>
<option>intellij-light.css</option>
<option>purebasic.css</option>
<option>qtcreator-dark.css</option>
<option>androidstudio.css</option>
Expand Down