Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enh(nsis) Update defines pattern #3417

Merged
merged 6 commits into from Dec 3, 2021
Merged

enh(nsis) Update defines pattern #3417

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
4fcb0d9
enh(nsis) Update defines pattern
idleberg Dec 3, 2021
dc5f6ab
Update CHANGES.md
idleberg Dec 3, 2021
21b2853
Update CHANGES.md
joshgoebel Dec 3, 2021
4cb23c8
fix: indent changelog correctly
idleberg Dec 3, 2021
b070f22
fix: add missing markdown link
idleberg Dec 3, 2021
d263421
Update CHANGES.md
joshgoebel Dec 3, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGES.md
View file
Open in desktop
Expand Up @@ -16,6 +16,7 @@ Grammars:
- enh(clojure) Add `regex` mode to regex literal
- fix(clojure) Remove inconsistent/broken highlighting for metadata
- enh(clojure) Add `punctuation` mode for commas.
- enh(nsis) Update defines pattern to allow `!` (#3417) [idleberg][]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add your name around line ~30 also. Each version needs the name repeated, even if you've contributed in the past.


Developer Tools:

Expand Down
2 changes: 1 addition & 1 deletion src/languages/nsis.js
View file
Open in desktop
Expand Up @@ -153,7 +153,7 @@ export default function(hljs) {
const DEFINES = {
// ${defines}
className: 'variable',
begin: /\$+\{[\w.:-]+\}/
begin: /\$+\{[\!\w.:-]+\}/
};

const VARIABLES = {
Expand Down