Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(clj) Fix broken/inconsistent highlighting for $, Numbers, namespaced maps, HINT mode. Add charachter, regex and punctuation modes. #3397

Merged
merged 13 commits into from Nov 10, 2021
Merged

fix(clj) Fix broken/inconsistent highlighting for $, Numbers, namespaced maps, HINT mode. Add charachter, regex and punctuation modes. #3397

merged 13 commits into from Nov 10, 2021

Commits on Nov 9, 2021

  1. Match names contianing $ 

    $ is the seperator for class names
    @MrEbbinghaus
    MrEbbinghaus committed Nov 9, 2021
    Copy the full SHA
    dd161d5 View commit details
    Browse the repository at this point in the history

  2. Add regex for all clojure number formats

    @MrEbbinghaus
    MrEbbinghaus committed Nov 9, 2021
    Copy the full SHA
    e1fda58 View commit details
    Browse the repository at this point in the history

  3. Add character highlighting

    @MrEbbinghaus
    MrEbbinghaus committed Nov 9, 2021
    Copy the full SHA
    c7f1f47 View commit details
    Browse the repository at this point in the history

  4. Fix inconsistent namespaced map highlighting

    @MrEbbinghaus
    MrEbbinghaus committed Nov 9, 2021
    Copy the full SHA
    7af493c View commit details
    Browse the repository at this point in the history

  5. Add regex highlighting

    @MrEbbinghaus
    MrEbbinghaus committed Nov 9, 2021
    Copy the full SHA
    82850bd View commit details
    Browse the repository at this point in the history

  6. Remove HINT mode from clojure 

    It is inconsistent with itself and other highlighters.
Also applies the wrong semantic mode
    @MrEbbinghaus
    MrEbbinghaus committed Nov 9, 2021
    Copy the full SHA
    7cd7549 View commit details
    Browse the repository at this point in the history

  7. Remove incorrect code from test

    @MrEbbinghaus
    MrEbbinghaus committed Nov 9, 2021
    Copy the full SHA
    3048320 View commit details
    Browse the repository at this point in the history

  8. Add punctuation mode for comma

    @MrEbbinghaus
    MrEbbinghaus committed Nov 9, 2021
    Copy the full SHA
    cbb6d4e View commit details
    Browse the repository at this point in the history

Commits on Nov 10, 2021

  1. Add latest clojure fixes to CHANGES.md

    @MrEbbinghaus
    MrEbbinghaus committed Nov 10, 2021
    Copy the full SHA
    5b45dbd View commit details
    Browse the repository at this point in the history

  2. Add more tests for different numbers 

    I noticed that other highlighters make mistakes with these, maybe this is close enough to a universal test set?
    @MrEbbinghaus
    MrEbbinghaus committed Nov 10, 2021
    Copy the full SHA
    f3c6a21 View commit details
    Browse the repository at this point in the history

  3. Break up Number regex into maintainable parts

    @MrEbbinghaus
    MrEbbinghaus committed Nov 10, 2021
    Copy the full SHA
    70c463f View commit details
    Browse the repository at this point in the history

  4. Break up Character regex into maintainable parts

    @MrEbbinghaus
    MrEbbinghaus committed Nov 10, 2021
    Copy the full SHA
    4ee86ac View commit details
    Browse the repository at this point in the history

  5. Set relevance for single character match to 0.

    @MrEbbinghaus
    MrEbbinghaus committed Nov 10, 2021
    Copy the full SHA
    0d1cdfe View commit details
    Browse the repository at this point in the history