Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(css/scss) single-colon psuedo-elements no longer break highlighting #3321

Merged
merged 2 commits into from Oct 7, 2021
Merged

fix(css/scss) single-colon psuedo-elements no longer break highlighting #3321

merged 2 commits into from Oct 7, 2021

Conversation

joshgoebel
Copy link
Member

@joshgoebel joshgoebel commented Sep 1, 2021 •
edited

Partial resolutoin of #3240.

Changes

Checklist

  • Added markup tests, or they don't apply here because...
  • Updated the changelog at CHANGES.md

allejo
allejo approved these changes Oct 7, 2021
View reviewed changes
Copy link
Member

@allejo allejo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems pretty sane to me. The only really really super edge case I found was mixing : and :: in the same ruleset.

image

But. If you're writing weird CSS like that, that's on you. So this gets a 👍 from me.

@joshgoebel
Copy link
Member Author

Yeah this is only a partial fix for #3240 - to prevent the broken attributes... I'm still not convinced the full fix is necessary... but someone else is welcome to PR the whole shebang if they find it more problematic.

@joshgoebel joshgoebel merged commit 0e0e7b2 into highlightjs:main Oct 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@allejo allejo allejo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@joshgoebel @allejo