(chore) fix dual package hazard #3200
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
joshgoebel
reviewed
May 19, 2021
| @@ -119,7 +119,10 @@ async function buildPackageJSON(options) { | |||
| ".": dual("./lib/index.js"), | |||
| "./package.json": "./package.json", | |||
| "./lib/common": dual("./lib/common.js"), | |||
| "./lib/core": dual("./lib/core.js"), | |||
| "./lib/core": { | |||
| get node() { return this.require; }, | |||
There was a problem hiding this comment.
Whoa. Does JSON.stringify automatically loop over getters or how does this work?
There was a problem hiding this comment.
Yep, it loops over all enumerable keys, and read its value by calling the getter in this case.
|
Closing, as mentioned elsewhere our |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To avoid dual package hazard in Node.js, it's important that the instance of hljs is shared across CJS and ESM modules.
Refs: #3188
Changes
This PR is disabling use of ESM for the
coremodule in Node.js, as ESM is able to import CJS modules but not the oother way around.