Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(docs) Small fixes in language guide and mode reference #3162

Merged
merged 7 commits into from May 2, 2021

Conversation

edemaine
Copy link
Contributor

I found a couple of small typos, and references to the old className, while reading the docs, so thought I'd push them along here.

Changes

  • Change className to scope, "name" to "scope"
  • Add link to Scopes Reference from Language Guide too (copied from Mode Reference). I don't know how to render reStructuredText so I assume this link renders OK but haven't verified.
  • Fix typo "many" to "must"

Checklist

  • Added markup tests, or they don't apply here because just changing documentation
  • Updated the changelog at CHANGES.md

@joshgoebel
Copy link
Member

This would need to be rebased on #3159 where I think I've already got most of this... it's just not in main yet.

@joshgoebel joshgoebel added this to the 11.0 beta 0 milestone Apr 23, 2021
@joshgoebel joshgoebel marked this pull request as draft April 24, 2021 06:34
@joshgoebel
Copy link
Member

@edemaine Any chance you'd like to possibly help out by doing some more reviewing of PRs? That's the big road block right now to forward momentum. If you'd like to help out there find me on Discord.

@edemaine
Copy link
Contributor Author

I tried rebasing onto #3159, and these changes seem to still be relevant (no conflicts).

@joshgoebel
Copy link
Member

Oh... maybe it's another PR then... we'll leave this be then until everything merges and then have a fresh look.

@joshgoebel
Copy link
Member

You were right, guess I missed these. Thanks so much!

@joshgoebel joshgoebel marked this pull request as ready for review May 2, 2021 02:28
@joshgoebel joshgoebel merged commit 9c2e909 into highlightjs:main May 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants