Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update agate.css #3161

Merged
merged 4 commits into from May 2, 2021
Merged

Update agate.css #3161

merged 4 commits into from May 2, 2021

Conversation

taufik-nurrohman
Copy link
Member

@joshgoebel
Copy link
Member

Missing selector .hljs-attr
Missing selector .hljs-template-tag
Theme does not fully support Templates/HTML/XML, etc..

Missing selector .hljs-selector-attr
Missing selector .hljs-selector-pseudo
Theme does not fully support CSS/Less/etc.

Missing selector .hljs-meta-keyword
Missing selector .hljs-meta-string
Theme does not fully support nice to haves (many code grammars use).

Missing selector .hljs-doctag
Missing selector .hljs-attr
Theme does not fully support program code.

See tools/checkTheme. Please add the missing selectors or IF these are purposeful omissions add empty rules so we know that you're choosing not to highlight them.

@joshgoebel
Copy link
Member

joshgoebel commented Apr 23, 2021

Also not wishing to draw any distinction between title.function and title.class?

Not saying that you have to, just a lot of themes do.

@taufik-nurrohman
Copy link
Member Author

Let me improve it tomorrow night GMT+07:00.

@taufik-nurrohman
Copy link
Member Author

taufik-nurrohman commented Apr 24, 2021

Arrgh!

Update: Okay done. Phew!

463e4e4f4acb9afc185a067b7f360321

@joshgoebel
Copy link
Member

@taufik-nurrohman Thanks so much!

@joshgoebel joshgoebel merged commit dfed4d0 into highlightjs:main May 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants