enh(autodetect) tcl: improve autodetection

[joshgoebel]

Pull TCL auto-detect changes into their own PR for closer inspection

Changes

Checklist

• Added markup tests, or they don't apply here because...
• Updated the changelog at CHANGES.md
• Added myself to AUTHORS.txt, under Contributors

[joshgoebel]

Refer to thoughts here: #2745 (comment)

[joshgoebel]

Upon taking a closer look at this I'm not sure array index should be part of variable at all... line 2 there looks "correct" to me... with () being unhighlighted and 1 being highlighted as a number.

I'm less sure what the correct answer is when the whole expresion is wrapped in {}:

${ns::other::name(32)}

Just to make forward progress it wouldn't bother me if this is all a variable but when not enclosed in ${} then we only highlight the $blah part. IE:

Are these all the same?

$name
${name}
${::name}
${name()}

[joshgoebel]

Or perhaps include number inside ${}:

[joshgoebel]

I've pretty much lost the thread here (been too long) but I think the original idea was the make the rules more precise and less likely to match false-positives... plus the rules are pretty unusual as written now IMHO...

[allejo]

Sorry I'm just getting around to this one, what do you want to do this? Just classify everything as variables?

Or perhaps include number inside ${}:

I think this one looks like it makes the most sense