enh(ruby) add support for real, imaginary, and e-notation numbers #2786
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshgoebel
reviewed
Oct 25, 2020
| @@ -128,7 +128,7 @@ export default function(hljs) { | |||
| }, | |||
| { | |||
| className: 'number', | |||
| begin: '(\\b0[0-7_]+)|(\\b0x[0-9a-fA-F_]+)|(\\b[1-9][0-9_]*(\\.[0-9_]+)?)|[0_]\\b', | |||
| begin: '(\\b0[0-7_]+)|(\\b0x[0-9a-fA-F_]+)|(\\b[1-9][0-9_]*(\\.[0-9_]+)?([ri]|[eE][-+]?[0-9_]+i?)?)|[0_]\\b', | |||
There was a problem hiding this comment.
Please break these out into variants as in the python?
joshgoebel
reviewed
Oct 25, 2020
| @@ -0,0 +1,3 @@ | |||
| number = 1.0e1_2 | |||
| number = 1.0e1_2i | |||
| number = 1.0r | |||
There was a problem hiding this comment.
A few more tests for 0. and some other edge cases?
joshgoebel
changed the title
joshgoebel
requested changes
Oct 25, 2020
3 tasks
|
Sorry @khamer I think that's accurate and we need to go with #2788 on this one. There are some other low hanging fruit issues if you'd like to find a different issue to contribute to. Not sure if you were jus looking to help out or really wanted to fix this one particular issue. Sorry for any confusion. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes to regex for matching numbers in ruby. Resolves #2766.
Changes
Changes the number regex for ruby to support exponential notation (1e123) as well as adding a trailing
rori- for real or imaginary numbers.Checklist
AUTHORS.txtunder Contributors