Fix Typescript markup for comment after enclosed lambda.

[mondeja]

This resolves #2189. Function params can't contains self.

[joshgoebel]

This is not correct output, please compare to https://github.com/highlightjs/highlight.js/blob/master/test/markup/typescript/functions.expect.txt (wrt: params wrapping)

The () aren't being wrapped or paired properly. The proper fix here is likely more complex.

[joshgoebel]

You would also need some tests for nested parenthesis inside arguments, which is likely what the self was trying to catch in the first place.

return this.sides.every((length,width=(3+2+(4/5))) => length > 0 );

They have to be properly paired so the first ) we see doesn't end the params.

[mondeja]

Yes, but Javascript has the same problem. At least this change produces the same output that JS language produces.

[joshgoebel]

In a perfect world I think simple cases would look something like:

const bad = ((a, b) => [...a, b]);
const bad = (a => [...a, b]);

bad = (<span class="hljs-function">(<span class="hljs-params">a, b</span>) =&gt;</span> [...a, b]);
bad = (<span class="hljs-function"><span class="hljs-params">a</span> =&gt;</span> [...a, b]);

[mondeja]

Ok, I see.

[joshgoebel]

Yes, but Javascript has the same problem. At least this change produces the same output that JS language produces.

Then it would seem they are both broken, just in different ways. Fixing some of these requires really digging in deep and understanding what is happening, why the rules are there, the different possible issues (like in this case nested parens), etc. My bet is this is one of the harder ones, but I"m not certain.

[joshgoebel]

I see you were trying to follow my last comment (thanks) but now that I've looked a little closer I don't think the fix here is just "do what JS does".

[joshgoebel]

------------v
const bad = ((a, b) => [...a, b]);

The problem here is that first ( is matched as the start of a function when it is not, it's just an expression. That's what someone needs to tackle here - this misdetection.

[joshgoebel]

If you're curious I believe this actually resolves the issue:

#2502