Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(javascript) comma is allowed in a "value container" #2403

Merged
merged 2 commits into from Feb 17, 2020

Commits on Feb 16, 2020

  1. fix(javascript) comma is allowed in a "value container"

    - fixes case where a regex would not be detected if it was anything
      other than the first parameter of a function call
    - in some cases this could actually cause the whole snippet to
      be flagged as illegal if the regex contained characters that
      were invalid at the top level (such as #)
    
    This complexity is because we only detect regexs inside "value
    containers" to prevent false positivies.
    
    This issue was found when asking Highlight.js to highlight it's
    own non-minified 1.2mb browser build.
    joshgoebel committed Feb 16, 2020
    Configuration menu
    Copy the full SHA
    c74d07d View commit details
    Browse the repository at this point in the history

Commits on Feb 17, 2020

  1. update changelog

    joshgoebel committed Feb 17, 2020
    Configuration menu
    Copy the full SHA
    46c067f View commit details
    Browse the repository at this point in the history