Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Omnis #2211

Closed
wants to merge 2 commits into from
Closed

Add Omnis #2211

wants to merge 2 commits into from

Conversation

jasongiss
Copy link

Support for the Omnis programming language, used by Omnis Studio.

@joshgoebel
Copy link
Member

We're currently in a large discussion about how to handle language submissions:

#2149

Currently the maintainers don't have the time to review or maintain any new languages and related issues - so we've been recommending that they be published as separate packages/repos. To see what that looks like:

https://github.com/highlightjs/highlightjs-robots-txt

Just a heads up.

@jasongiss
Copy link
Author

Thanks very much for the pointer, @yyyc514.

That is an interesting read, and I feel for the position you maintainers are in.

I am happy to wait until a decision is made on how best to handle new languages - good luck with that!

@egor-rogov
Copy link
Collaborator

@jasongiss are you willing to maintain this language? I can spin up a repo for it.

@joshgoebel
Copy link
Member

@jasongiss Any chance you'd be willing to maintain/contribute to other people's grammars (not just your own) on a semi-regular basis - or triage issues or something? I've been pushing for the idea of a "community" repository to keep all (or many) of the languages in (to make this whole process simpler, to make building a single "binary" from many sources simpler, etc.), but it only works if we can find people to maintain it.

Ie, in my imaginary world you'd just submit a PR there, the community would review it and once it was ready it'd be merged into a larger world - and we'd all look out for it - rather than having it locked away in a separate repository.

@jasongiss
Copy link
Author

@egor-rogov I would certainly be willing to maintain a repo for the Omnis language.

@yyyc514 I'm very sorry, but I really don't have enough free time at the moment (and probably not the expertise) to be able to commit to helping maintain a "community" repo.
I can put time into maintaining the Omnis language, as I work on the Omnis development team, so I can do that on 'work time'.
I'm happy whether that's in a separate repo, or a community repo (I just wouldn't be able to put much time into other languages).

For our particular use-case, it's nice to be able to build a single JS package with our language embedded (which I guess would be more likely with the community repo?), but happy to go with whatever the official technique becomes.
The main thing for us is just having a central place where the language definition can be found and contributed to.

@joshgoebel
Copy link
Member

I can put time into maintaining the Omnis language, as I work on the Omnis development team, so I can do that on 'work time'.

Nice.

For our particular use-case, it's nice to be able to build a single JS package with our language embedded (which I guess would be more likely with the community repo?)

Not sure likely is the right word. I want it to be easy no matter where the cards fall on structure of repositories. Just we aren’t there yet.

It’s not particularly hard now - for a single language - just very manual.

@jasongiss
Copy link
Author

Not sure likely is the right word. I want it to be easy no matter where the cards fall on structure of repositories. Just we aren’t there yet.

It’s not particularly hard now - for a single language - just very manual.

I agree - the process currently works well, it just needs a clever solution for adding languages in a maintainable way.

@joshgoebel joshgoebel changed the title Omnis language support Add Omnis Oct 24, 2019
@joshgoebel
Copy link
Member

@jasongiss

#2328

@joshgoebel
Copy link
Member

joshgoebel commented Dec 19, 2019

Closing this as discussion can now continue on #2328.

@joshgoebel joshgoebel closed this Dec 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants