Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add languages to the :common list #2204

Merged
merged 1 commit into from
Oct 24, 2019

Conversation

joshgoebel
Copy link
Member

No description provided.

@joshgoebel
Copy link
Member Author

Discussion here.

#1119

Once we're decided I can type up a nicer changelog message.

@joshgoebel joshgoebel changed the title add langauges to the common list add langauges to the :common list Oct 14, 2019
@joshgoebel joshgoebel added enhancement An enhancement or new feature parser labels Oct 14, 2019
@joshgoebel joshgoebel changed the title add langauges to the :common list add languages to the :common list Oct 14, 2019
Copy link
Collaborator

@egor-rogov egor-rogov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, I think it's make sense to refresh the list from time to time.
And what about coffeescript?

I am worried a bit by lack of a clear criterion though. Maybe we can/should get access to some statistics from github or something like that?

@joshgoebel
Copy link
Member Author

joshgoebel commented Oct 14, 2019

And what about coffeescript?

I say leave it, it's small. These files are all so small. :-) Powershell is the only pseudo-popular annoying sized package, but even it blends in decently.

-rw-r--r--  1 jgoebel  staff  130977 Oct 14 19:10 highlight.medium.pack.js
-rw-r--r--  1 jgoebel  staff   71161 Oct 14 19:10 highlight.pack.js

I am worried a bit by lack of a clear criterion though. Maybe we can/should get access to some statistics from github or something like that?

Sure, whatever. :-) Suggestion?

@joshgoebel
Copy link
Member Author

Screen Shot 2019-10-14 at 7 12 15 PM

@joshgoebel
Copy link
Member Author

We don't even have SQLPL or HCL. :-)

@egor-rogov
Copy link
Collaborator

I am worried a bit by lack of a clear criterion though. Maybe we can/should get access to some statistics from github or something like that?

Sure, whatever. :-) Suggestion?

Just a thought for the future. It requires some research and I don't feel like doing it now. I'm personally fine with the list you suggested.

@joshgoebel
Copy link
Member Author

Would you want to go ahead and add Powershell (because it's popular) and bump the minimal build from 70kb to 105kb or so?

@egor-rogov
Copy link
Collaborator

Honestly I have no definite opinion on this. It's up to you (:

@joshgoebel joshgoebel added this to the 9.15.11 milestone Oct 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement An enhancement or new feature parser
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants