Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add xtlang #1902

Closed
wants to merge 1 commit into from
Closed

Add xtlang #1902

wants to merge 1 commit into from

Conversation

cyblue9
Copy link
Contributor

@cyblue9 cyblue9 commented Nov 7, 2018

Support for xtlang language.
(Issue: extemporelang#1)

xtlang syntax looks like scheme, but xtlang has type system and is compiler language.
It is used in Extempore.

This is inspired by pygments one.

Please review!

@benswift
Copy link

benswift commented Nov 9, 2018

Hey, I'm one of the core Extempore developers, so if you have any questions from that side of things I'm happy to help out 😄

@marcoscaceres
Copy link
Contributor

marcoscaceres commented Nov 9, 2018

Hi @cyblue9, @benswift, we are looking at moving languages into their own repositories, for example:
https://github.com/highlightjs/highlightjs-cshtml-razor

That way, they can be included seperately to our core library and can be maintained independently. There are a few kinks we are still working out, but if you are interested, I can create a repository for you at the org level, and you can maintain your language there.

@marcoscaceres
Copy link
Contributor

hehe, not "indecently" - independently. Autocorrect win!

@benswift
Copy link

benswift commented Nov 9, 2018

Wow - a scandalous proposal 😉

Sure, if that's the way it's going anyway then I'm happy to have it in a separate repo under the hljs org. That way we don't have to hassle the core team as we squash the edge cases (which I'm sure there'll be a few of initially).

Is it already possible to build hljs with support for one of these "language modules"? Or do I need to hack the build script manually?

@cyblue9
Copy link
Contributor Author

cyblue9 commented Nov 9, 2018

Thank @marcoscaceres for comment!

Since I am one of contributor of extempore, so I will leave the future policy to @benswift .
(I will keep my responsibility for the code I wrote.)

@marcoscaceres
Copy link
Contributor

Is it already possible to build hljs with support for one of these "language modules"? Or do I need to hack the build script manually?

Depends... ideally, if you are using a bundler web pack, you can just import the language in and WebPack will take care of it. However, we are still trying to work out the details.

@marcoscaceres
Copy link
Contributor

@cyblue9, @benswift, gave you both admin over in https://github.com/highlightjs/highlightjs-xtlang

Again, take a look at the structure for:
https://github.com/highlightjs/highlightjs-cshtml-razor

Basically, you should hopefully be able to copy that. Apologies for not having proper instructions yet, we are super resource restrained on the project as it's just a small handful of people in the community trying to maintain it.

@benswift
Copy link

Great, acknowledged. @cyblue9 , are you happy to look at that cshtml-razor repo and package up the xtlang one in a similar way?

Re: resource constraints, I get it - we appreciate all the work you guys do 🙌

@marcoscaceres
Copy link
Contributor

@cyblue9, we have a Slack channel that I can invite you to if you have any questions or need some additional help. I'll need an email to invite you. You can either email me (marcos@marcosc.com) or post it here and I'll send you an invite.

@cyblue9
Copy link
Contributor Author

cyblue9 commented Nov 12, 2018

@marcoscaceres
Thank you to create highlightjs-xtlang repo. Good job!😁

You can either email me (marcos@marcosc.com) or post it here and I'll send you an invite.

OK! This is my email address.

Thank to invite me.

@benswift

are you happy to look at that cshtml-razor repo and package up the xtlang one in a similar way?

Yes! I will try it!
After I package up it, please review it.🙏

@benswift
Copy link

After I package up it, please review it.🙏

Will do for sure 🙂

@cyblue9
Copy link
Contributor Author

cyblue9 commented Nov 15, 2018

Hi, @marcoscaceres @benswift!

Finished creating highlightjs-xtlang repo !
(Sorry, to be late...)

Plase review and modfiy!

  • Sentence of README

@benswift
Copy link

Great, really nice work. I'll be finished marking next week and will have a look at this asap.

@joshgoebel joshgoebel changed the title Add support for xtlang Add xtlang Oct 24, 2019
@joshgoebel
Copy link
Member

joshgoebel commented Dec 24, 2019

@benswift @cyblue9

Is it already possible to build hljs with support for one of these "language modules"? Or do I need to hack the build script manually?

This is possible now with my new build system PR:

#2312

It should land in version 10, sometime in Jan 2020. But you can use it now to see how it works and make it easier to work with your language modules.

And related discussion on 3rd party repos:

#2328

As marcoscaceres mentioned you also have options with just npm and basic requires stuff as well (assuming you also publish your 3rd party module as a npm package)... what my PR makes easy is if you want to build a SINGLE monolithichighlight.js that includes 3rd party languages, or want to easily publish your own CDN modules, or build your own custom npm package from scratch.

Closing this PR since we now have https://github.com/highlightjs/highlightjs-xtlang. Always happy to answer any questions or concerns though!

@joshgoebel joshgoebel closed this Dec 24, 2019
@benswift
Copy link

benswift commented Jan 5, 2020

Great, thanks @yyyc514

Sorry about the delayed reply - I've been on holidays.

@cyblue9
Copy link
Contributor Author

cyblue9 commented Jan 6, 2020

@yyyc514

Nice! Good job! Thank you😀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants